Skip to content

Add ubuntu specific check and remediation for aide_periodic_checking_systemd_timer#12733

Merged
dodys merged 3 commits into
ComplianceAsCode:masterfrom
mpurg:ubuntu2404_cis_6.3.2
Dec 17, 2024
Merged

Add ubuntu specific check and remediation for aide_periodic_checking_systemd_timer#12733
dodys merged 3 commits into
ComplianceAsCode:masterfrom
mpurg:ubuntu2404_cis_6.3.2

Conversation

@mpurg
Copy link
Copy Markdown
Contributor

@mpurg mpurg commented Dec 17, 2024

Description:

  • Add ubuntu specific check and remediation for aide_periodic_checking_systemd_timer
  • Add rules to ubuntu2404 CIS control 6.3.2

Rationale:

  • fixed OVAL to use correct filenames for systemd unit files
  • fixed OVAL to check if dailyaidecheck.service is 'static' instead of 'enabled'
  • fixed remediation to not create systemd unit files since these
    are shipped with the aide package on Ubuntu 24.04

mpurg added 2 commits December 17, 2024 10:54
@mpurg
Add ubuntu specific check and remediation for aide_periodic_checking_…
72f648c 
…systemd_timer

- fixed OVAL to use correct filenames for systemd unit files
- fixed OVAL to check if dailyaidecheck.service is 'static' instead of 'enabled'
- fixed remediation to not create systemd unit files since these
  are shipped with the aide package on Ubuntu 24.04
@mpurg
Add rules to ubuntu2404 CIS control 6.3.2
f03793f
@mpurg mpurg requested a review from a team as a code owner December 17, 2024 10:00
@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 17, 2024
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 17, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 17, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@dodys dodys self-assigned this Dec 17, 2024
@dodys dodys added Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. Update Rule Issues or pull requests related to Rules updates. labels Dec 17, 2024
@dodys dodys added this to the 0.1.76 milestone Dec 17, 2024
@mpurg
Copy link
Copy Markdown
Contributor Author

mpurg commented Dec 17, 2024

Automatus tests are failing in podman because environment fails to prepare due to missing systemd. See issue #12511
Tests are passing locally in KVM.

@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented Dec 17, 2024

Code Climate has analyzed commit 13ab1b9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

dodys
dodys approved these changes Dec 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit ec6dccf into ComplianceAsCode:master Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels

CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates. Update Rule Issues or pull requests related to Rules updates.

Projects

None yet

Milestone

0.1.76

Development

Successfully merging this pull request may close these issues.

2 participants

@mpurg @dodys