Skip to content

Ubuntu 24.04 2.4.2.1 Ensure at is restricted to authorized users#12711

Merged
dodys merged 5 commits into
ComplianceAsCode:masterfrom
ericeberry:u2404_2421
Dec 19, 2024
Merged

Ubuntu 24.04 2.4.2.1 Ensure at is restricted to authorized users#12711
dodys merged 5 commits into
ComplianceAsCode:masterfrom
ericeberry:u2404_2421

Conversation

@ericeberry
Copy link
Copy Markdown
Contributor

@ericeberry ericeberry commented Dec 12, 2024

Description:

  • 2.4.2.1 Ensure at is restricted to authorized users

Rationale:

  • Implement 2.4.2.1 Ensure at is restricted to authorized users

@ericeberry ericeberry requested a review from a team as a code owner December 12, 2024 22:08
@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 12, 2024
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 12, 2024

Hi @ericeberry. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 12, 2024 •
edited
Loading

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 added this to the 0.1.76 milestone Dec 12, 2024
mpurg
mpurg requested changes Dec 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mpurg mpurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes needed

Comment thread linux_os/guide/services/cron_and_at/restrict_at_cron_users/file_at_deny_exists/rule.yml Outdated
Comment thread linux_os/guide/services/cron_and_at/restrict_at_cron_users/file_groupowner_at_deny/rule.yml
Comment thread controls/cis_ubuntu2404.yml Outdated
@dodys dodys self-assigned this Dec 16, 2024
@dodys dodys added Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. New Rule Issues or pull requests related to new Rules. labels Dec 16, 2024
mpurg
mpurg requested changes Dec 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mpurg mpurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes needed

Comment thread controls/cis_ubuntu2404.yml Outdated
Comment thread components/cronie.yml Outdated
@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented Dec 17, 2024

Code Climate has analyzed commit 7122ad9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

dodys
dodys approved these changes Dec 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit ff8de8b into ComplianceAsCode:master Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpurg mpurg mpurg requested changes

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels

CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. New Rule Issues or pull requests related to new Rules. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.

Projects

None yet

Milestone

0.1.76

Development

Successfully merging this pull request may close these issues.

4 participants

@ericeberry @dodys @mpurg @Mab879