Skip to content

Add rules to several ubuntu2404 CIS controls#12675

Merged
dodys merged 2 commits into
ComplianceAsCode:masterfrom
mpurg:ubuntu2404_cis_rules1
Dec 10, 2024
Merged

Add rules to several ubuntu2404 CIS controls#12675
dodys merged 2 commits into
ComplianceAsCode:masterfrom
mpurg:ubuntu2404_cis_rules1

Conversation

@mpurg
Copy link
Copy Markdown
Contributor

@mpurg mpurg commented Dec 5, 2024

Description:

  • add rules to several Ubuntu 24.04 CIS controls
  • fix package name for libpam-pwquality on Ubuntu 24.04

@mpurg mpurg requested a review from a team as a code owner December 5, 2024 13:00
@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 5, 2024
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 5, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 5, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@mpurg mpurg force-pushed the ubuntu2404_cis_rules1 branch from 3b57473 to 68498f9 Compare December 5, 2024 13:04
@dodys dodys self-assigned this Dec 5, 2024
@dodys dodys added Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates. Update Rule Issues or pull requests related to Rules updates. labels Dec 5, 2024
@dodys dodys added this to the 0.1.76 milestone Dec 5, 2024
@mpurg mpurg force-pushed the ubuntu2404_cis_rules1 branch from 3c098a6 to 2d47472 Compare December 6, 2024 08:38
@mpurg mpurg force-pushed the ubuntu2404_cis_rules1 branch from 2d47472 to 3dd04b6 Compare December 10, 2024 10:56
@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented Dec 10, 2024

Code Climate has analyzed commit 3dd04b6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

dodys
dodys approved these changes Dec 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 93ba08a into ComplianceAsCode:master Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels

needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates. Update Rule Issues or pull requests related to Rules updates.

Projects

None yet

Milestone

0.1.76

Development

Successfully merging this pull request may close these issues.

2 participants

@mpurg @dodys