Remove redundant sshd oval macro#12532
Merged
jan-cerny merged 2 commits intoOct 24, 2024
Merged
Conversation
the original macro was used only in this rule and it effectively duplicated the sshd_oval_check with some limitations
|
Start a new ephemeral environment with changes proposed in this pull request: kylinserver10 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
|
This datastream diff is auto generated by the check Click here to see the full diffOVAL for rule 'xccdf_org.ssgproject.content_rule_sshd_use_strong_ciphers' differs.
--- oval:ssg-sshd_use_strong_ciphers:def:1
+++ oval:ssg-sshd_use_strong_ciphers:def:1
@@ -5,5 +5,7 @@
criteria AND
extend_definition oval:ssg-sshd_required_or_unset:def:1
extend_definition oval:ssg-package_openssh-server_installed:def:1
-criteria OR
+criteria AND
+criteria AND
criterion oval:ssg-test_sshd_use_strong_ciphers:tst:1
+criterion oval:ssg-test_Ciphers_present_sshd_use_strong_ciphers:tst:1 |
|
Code Climate has analyzed commit 87dd7be and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 60.9% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Oct 24, 2024
Collaborator
jan-cerny
left a comment
There was a problem hiding this comment.
I have add the rule sshd_use_strong_ciphers to RHEL 9 default profile and built the content. Then, I have run Automatus test scenarios.
jcerny@fedora:~/work/git/scap-security-guide (pr/12532)$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel9 sshd_use_strong_ciphers
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2024-10-24-1350/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_sshd_use_strong_ciphers
INFO - Script good_cipher.pass.sh using profile (all) OK
INFO - Script no_ciphers.fail.sh using profile (all) OK
jcerny@fedora:~/work/git/scap-security-guide (pr/12532)$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel9 --remediate-using ansible sshd_use_strong_ciphers
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2024-10-24-1351/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_sshd_use_strong_ciphers
INFO - Script good_cipher.pass.sh using profile (all) OK
INFO - Script no_ciphers.fail.sh using profile (all) OK
WARNING - No remediation is available for rule 'xccdf_org.ssgproject.content_rule_sshd_use_strong_ciphers'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
Review Hints: