Skip to content

Add rule accounts_tmout to SLE Micro 5 STIG profile#12524

Merged
teacup-on-rockingchair merged 5 commits into
ComplianceAsCode:masterfrom
svet-se:slmicro5-stig-add-rule-accounts_tmout
Oct 28, 2024
Merged

Add rule accounts_tmout to SLE Micro 5 STIG profile#12524
teacup-on-rockingchair merged 5 commits into
ComplianceAsCode:masterfrom
svet-se:slmicro5-stig-add-rule-accounts_tmout

Conversation

@svet-se
Copy link
Copy Markdown
Contributor

@svet-se svet-se commented Oct 22, 2024

Description:

  • Add rule accounts_tmout to SLE Micro 5 STIG profile. Fix check_id: system_with_kernel to support SLE. Update status of SLEM-05-211015 and SLEM-05-653060 to manual

Rationale:

  • According to DISA SLE Micro 5 STIG Version 1, Release: 1 Benchmark Date: 13 Jun 2024

@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Oct 22, 2024
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 22, 2024

Hi @svet-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 22, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@teacup-on-rockingchair teacup-on-rockingchair added the SLES SUSE Linux Enterprise Server product related. label Oct 22, 2024
@svet-se svet-se mentioned this pull request Oct 23, 2024
Closed
@teacup-on-rockingchair teacup-on-rockingchair force-pushed the slmicro5-stig-add-rule-accounts_tmout branch from bb09783 to 412220f Compare October 27, 2024 15:10
@teacup-on-rockingchair teacup-on-rockingchair added this to the 0.1.75 milestone Oct 27, 2024
@teacup-on-rockingchair teacup-on-rockingchair added Ansible Ansible remediation update. Bash Bash remediation update. Update Profile Issues or pull requests related to Profiles updates. OVAL OVAL update. Related to the systems assessments. labels Oct 27, 2024
@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented Oct 27, 2024

Code Climate has analyzed commit 412220f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

teacup-on-rockingchair
teacup-on-rockingchair approved these changes Oct 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@teacup-on-rockingchair teacup-on-rockingchair merged commit b448c05 into ComplianceAsCode:master Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teacup-on-rockingchair teacup-on-rockingchair teacup-on-rockingchair approved these changes

Assignees

@teacup-on-rockingchair teacup-on-rockingchair

Labels

Ansible Ansible remediation update. Bash Bash remediation update. needs-ok-to-test Used by openshift-ci bot. OVAL OVAL update. Related to the systems assessments. SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates.

Projects

None yet

Milestone

0.1.75

Development

Successfully merging this pull request may close these issues.

2 participants

@svet-se @teacup-on-rockingchair