Add rules to support remote offload of journal logs by teacup-on-rockingchair · Pull Request #12479 · ComplianceAsCode/content

teacup-on-rockingchair · 2024-10-08T12:50:49Z

Description:

Add rules to support remote offload of journal logs to Slmicro5 STIG

Rationale:

Add rules and remediations to configure remote url, tls certificate and key for connecting to remote journal
Add external variables: var_journal_upload_url, var_journal_upload_server_certificate_file,var_journal_upload_server_trusted_certificate_file, var_journal_upload_server_key_file, that user can configure relevant settings

openshift-ci · 2024-10-08T12:50:53Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

github-actions · 2024-10-08T12:52:09Z

Start a new ephemeral environment with changes proposed in this pull request:

slmicro5 (from CTF) Environment (using Fedora as testing environment)

Fedora Testing Environment

Oracle Linux 8 Environment

github-actions · 2024-10-08T12:54:48Z

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff

New data stream adds bash remediation for rule 'xccdf_org.ssgproject.content_rule_service_firewalld_enabled'.
New data stream adds bash remediation for rule 'xccdf_org.ssgproject.content_rule_service_sshd_enabled'.
New data stream adds bash remediation for rule 'xccdf_org.ssgproject.content_rule_service_auditd_enabled'.

github-actions · 2024-10-08T13:11:00Z

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12479
This image was built from commit: 187c15f

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12479

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12479 make deploy-local

Mab879 · 2024-10-15T15:45:59Z

I'm waving the automatus failures as they are due to rule not being the data streams.

Mab879

Thanks for the PR, just a few small changes.

Mab879 · 2024-10-16T17:13:13Z

/packit build

Mab879

Just one minor thing I missed in my first review, sorry about that.

Mab879

Thanks!

Mab879

Please rebase, looks like something is conflicting.

teacup-on-rockingchair · 2024-10-22T06:25:04Z

Please rebase, looks like something is conflicting.

Done thanks 🙇

- Add rules and remediations to configure remote url, tls certificate and key for connecting to remote journal - Add external variables: var_journal_upload_url, var_journal_upload_server_certificate_file,var_journal_upload_server_trusted_certificate_file, var_journal_upload_server_key_file, that user can configure relevant settings

…-upload_enabled/rule.yml Co-authored-by: Matthew Burket <m@tthewburket.com>

…url/rule.yml Co-authored-by: Matthew Burket <m@tthewburket.com>

…server_tls/rule.yml Co-authored-by: Matthew Burket <m@tthewburket.com>

Co-authored-by: Matthew Burket <m@tthewburket.com>

… as it depends on specific external variables

qlty-cloud-legacy · 2024-10-22T09:48:56Z

Code Climate has analyzed commit 1d40a70 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.0% (0.0% change).

View more on Code Climate.

Mab879

Thanks!

openshift-ci Bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Oct 8, 2024

teacup-on-rockingchair force-pushed the slmicro_journal_upload branch from 257858f to 187c15f Compare October 9, 2024 06:09

teacup-on-rockingchair marked this pull request as ready for review October 14, 2024 19:52

openshift-ci Bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Oct 14, 2024

teacup-on-rockingchair added Ansible Ansible remediation update. Bash Bash remediation update. SLES SUSE Linux Enterprise Server product related. Update Template Issues or pull requests related to Templates updates. labels Oct 14, 2024

teacup-on-rockingchair added this to the 0.1.75 milestone Oct 15, 2024

teacup-on-rockingchair requested a review from Mab879 October 15, 2024 03:46

Mab879 self-assigned this Oct 15, 2024

Mab879 requested changes Oct 15, 2024

View reviewed changes

Mab879 reviewed Oct 16, 2024

View reviewed changes

Comment thread shared/templates/service_enabled/bash.template Outdated

Mab879 approved these changes Oct 17, 2024

View reviewed changes

Mab879 requested changes Oct 17, 2024

View reviewed changes

openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Oct 17, 2024

teacup-on-rockingchair force-pushed the slmicro_journal_upload branch from 7277de8 to 2bb738a Compare October 22, 2024 06:24

openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Oct 22, 2024

teacup-on-rockingchair added 5 commits October 22, 2024 11:49

Add service enable bash remediation support for slmicro5

999e399

Assign CCE ids for journal rules in slmicro5

a9db42c

Add journal remote upload rules and drop trailing whitespaces

e2b8967

Assign rules to relevant components

20a0008

teacup-on-rockingchair and others added 5 commits October 22, 2024 11:50

Update linux_os/guide/system/logging/journald/service_systemd-journal…

97c0c4f

…-upload_enabled/rule.yml Co-authored-by: Matthew Burket <m@tthewburket.com>

Update linux_os/guide/system/logging/journald/service_systemd-journal…

5fcf307

…-upload_enabled/rule.yml Co-authored-by: Matthew Burket <m@tthewburket.com>

Update linux_os/guide/system/logging/journald/systemd_journal_upload_…

b216a6d

…url/rule.yml Co-authored-by: Matthew Burket <m@tthewburket.com>

Update linux_os/guide/system/logging/journald/systemd_journal_upload_…

c5eec6c

…server_tls/rule.yml Co-authored-by: Matthew Burket <m@tthewburket.com>

Update shared/templates/service_enabled/bash.template

7ee3f44

Co-authored-by: Matthew Burket <m@tthewburket.com>

teacup-on-rockingchair force-pushed the slmicro_journal_upload branch from 2bb738a to 7ee3f44 Compare October 22, 2024 08:50

Mark in the control the remediation should be run manual for this one…

1d40a70

… as it depends on specific external variables

Mab879 approved these changes Oct 22, 2024

View reviewed changes

Mab879 merged commit 856d9c5 into ComplianceAsCode:master Oct 22, 2024

Conversation

teacup-on-rockingchair commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Rationale:

Uh oh!

openshift-ci Bot commented Oct 8, 2024

Uh oh!

github-actions Bot commented Oct 8, 2024

Uh oh!

github-actions Bot commented Oct 8, 2024

Uh oh!

github-actions Bot commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mab879 commented Oct 15, 2024

Uh oh!

Mab879 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mab879 commented Oct 16, 2024

Uh oh!

Mab879 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Mab879 left a comment

Choose a reason for hiding this comment

Uh oh!

Mab879 left a comment

Choose a reason for hiding this comment

Uh oh!

teacup-on-rockingchair commented Oct 22, 2024

Uh oh!

qlty-cloud-legacy Bot commented Oct 22, 2024

Uh oh!

Mab879 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

teacup-on-rockingchair commented Oct 8, 2024 •

edited

Loading

github-actions Bot commented Oct 8, 2024 •

edited

Loading