Skip to content

RHEL 9 STIG: change remediated Networkmanager DNS mode#12448

Merged
Mab879 merged 1 commit into
ComplianceAsCode:masterfrom
vojtapolasek:fix_stig_rhel9_dns_nm
Oct 1, 2024
Merged

RHEL 9 STIG: change remediated Networkmanager DNS mode#12448
Mab879 merged 1 commit into
ComplianceAsCode:masterfrom
vojtapolasek:fix_stig_rhel9_dns_nm

Conversation

@vojtapolasek
Copy link
Copy Markdown
Collaborator

@vojtapolasek vojtapolasek commented Oct 1, 2024

Description:

  • change the mode used in remediation from "none" to "default"
  • also modify profile stability data

Rationale:

Review Hints:

  • build the rhel9 product and review the resulting profile

@vojtapolasek vojtapolasek added RHEL9 Red Hat Enterprise Linux 9 product related. Update Profile Issues or pull requests related to Profiles updates. STIG STIG Benchmark related. labels Oct 1, 2024
@vojtapolasek vojtapolasek added this to the 0.1.75 milestone Oct 1, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 1, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 1, 2024 •
edited
Loading

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12448
This image was built from commit: 47264e6

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12448

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12448 make deploy-local

@marcusburghardt marcusburghardt self-assigned this Oct 1, 2024
marcusburghardt
marcusburghardt approved these changes Oct 1, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@marcusburghardt
Copy link
Copy Markdown
Member

marcusburghardt commented Oct 1, 2024

CI tests are failing with STIG. We need to investigate the failure.

@vojtapolasek
Copy link
Copy Markdown
Collaborator Author

vojtapolasek commented Oct 1, 2024

@marcusburghardt I think I know what is the problem, the problem is the "default" selector. I am working on a fix.

@vojtapolasek vojtapolasek force-pushed the fix_stig_rhel9_dns_nm branch from fe76b61 to 47264e6 Compare October 1, 2024 14:39
@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented Oct 1, 2024

Code Climate has analyzed commit 47264e6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 merged commit 1af8588 into ComplianceAsCode:master Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mab879 Mab879 Mab879 approved these changes

@marcusburghardt marcusburghardt marcusburghardt approved these changes

Assignees

@marcusburghardt marcusburghardt

Labels

RHEL9 Red Hat Enterprise Linux 9 product related. STIG STIG Benchmark related. Update Profile Issues or pull requests related to Profiles updates.

Projects

None yet

Milestone

0.1.75

Development

Successfully merging this pull request may close these issues.

3 participants

@vojtapolasek @marcusburghardt @Mab879