Skip to content

add rule sysctl_kernel_modules_disabled to unselect_rules_list#12354

Merged
Mab879 merged 1 commit into
ComplianceAsCode:masterfrom
vojtapolasek:add_rule_disabling_modules_to_unselect_rules_list
Aug 30, 2024
Merged

add rule sysctl_kernel_modules_disabled to unselect_rules_list#12354
Mab879 merged 1 commit into
ComplianceAsCode:masterfrom
vojtapolasek:add_rule_disabling_modules_to_unselect_rules_list

Conversation

@vojtapolasek
Copy link
Copy Markdown
Collaborator

@vojtapolasek vojtapolasek commented Aug 30, 2024

Description:

  • Description here. Replace this text. Don't use the italics format!

Rationale:

this rule has stil enabled Ansible remediation.
When testing rhel10 product in a VM, it prevents the systemfrom loading module for virtio network after reboot, effectively disrupting the testing.

Review Hints:

./build_product rhel10
cd tests
./ds_unselect_rules.sh  ../build/ssg-rhel10-ds.xml  unselect_rules_list 
python automatus.py profile --libvirt <your_qemu_conection> <your_vm_name> --datastream /tmp/ssg-rhel10-ds.xml --remediate-using ansible anssi_bp28_high

Before applying the fix, the machine will reboot but after logging in through console, there will be no network interfaces available except for localhost.
After the fix the network should work normally.

@vojtapolasek
add rule sysctl_kernel_modules_disabled to unselect_rules_list
153fe42 
this rule has stil enabled Ansible remediation.
When testing rhel10 product in a VM, it prevents the systemfrom loading module for virtio network after reboot, effectively  disrupting the testing.
@vojtapolasek vojtapolasek added the Test Suite Update in Test Suite. label Aug 30, 2024
@vojtapolasek vojtapolasek added this to the 0.1.75 milestone Aug 30, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 30, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 30, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12354
This image was built from commit: 153fe42

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12354

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12354 make deploy-local

@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented Aug 30, 2024

Code Climate has analyzed commit 153fe42 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Aug 30, 2024
@Mab879
Copy link
Copy Markdown
Member

Mab879 commented Aug 30, 2024

/packit retest-failed

Mab879
Mab879 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mab879 Mab879 merged commit f02f47f into ComplianceAsCode:master Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels

Test Suite Update in Test Suite.

Projects

None yet

Milestone

0.1.75

Development

Successfully merging this pull request may close these issues.

2 participants

@vojtapolasek @Mab879