Skip to content

Ubuntu 22.04 STIG V2R1 changes#12298

Merged
dodys merged 3 commits into
ComplianceAsCode:masterfrom
ericeberry:master
Aug 20, 2024
Merged

Ubuntu 22.04 STIG V2R1 changes#12298
dodys merged 3 commits into
ComplianceAsCode:masterfrom
ericeberry:master

Conversation

@ericeberry
Copy link
Copy Markdown
Contributor

@ericeberry ericeberry commented Aug 13, 2024

Description:

  • Changes to reflect the updates in Ubuntu 22.04 STIG V2R1

Rationale:

  • Part of Ubuntu 22.04 DISA STIG v1r12 profile upgrade

Review Hints:

  • Build the product:
    ./build_product ubuntu2004

  • To test these changes, please ensure that the remediation headers are updated to V2R1.

  • The Manual STIG is the current latest version, and was obtained from DISA's website. For reference, please review: https://public.cyber.mil/stigs/downloads/

@ericeberry ericeberry requested a review from a team as a code owner August 13, 2024 19:01
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 13, 2024

Hi @ericeberry. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Aug 13, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 13, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 13, 2024 •
edited
Loading

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12298
This image was built from commit: 0df3c5d

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12298

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12298 make deploy-local

@dodys dodys added this to the 0.1.75 milestone Aug 14, 2024
@dodys dodys added Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates. STIG STIG Benchmark related. labels Aug 14, 2024
@dodys
Copy link
Copy Markdown
Contributor

dodys commented Aug 14, 2024

/packit build

dodys
dodys requested changes Aug 14, 2024
View reviewed changes
Comment thread controls/srg_gpos/SRG-OS-000366-GPOS-00153.yml
Comment thread controls/srg_gpos/SRG-OS-000356-GPOS-00144.yml
@dodys dodys self-assigned this Aug 14, 2024
@ericeberry ericeberry requested a review from dodys August 15, 2024 14:38
dodys
dodys requested changes Aug 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few things to include

Comment thread products/ubuntu2204/profiles/stig.profile
@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented Aug 20, 2024

Code Climate has analyzed commit 0df3c5d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

dodys
dodys approved these changes Aug 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit aa881c3 into ComplianceAsCode:master Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels

needs-ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.

Projects

None yet

Milestone

0.1.75

Development

Successfully merging this pull request may close these issues.

2 participants

@ericeberry @dodys