Review and update install_vm.py script#12254
Conversation
This option is necessary to virt-install command when a system can't be detected, for example when a not yet released product needs to be provisioned for testing. Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
VMs installed with this script are in general for test. Sometimes they fail and we need to isolate the issue. So now the virt-install command is always shown before starting the installation to make things easier. Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Replace the traditional call for format method for its shorter alternative. This makes the lines easier to be read and maintained. Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Just included RHEL 10 comment. Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
|
Code Climate has analyzed commit dd705b8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
|
/test 4.13-images |
Description:
This script helps us to quickly deploy a VM for content tests.
When I tried to use it to create a RHEL 10 VM, I got errors and the installation didn't succeed.
Trying to investigate the issue I saw opportunities to improve the script.
So I decided to fix the current issues and refactor it make it simpler, more flexible and easier to be used.
Rationale:
Better tooling for maintainers.
Review Hints:
Try to install a RHEL 10 vm using the
install_vm.pyscript.