Disable service_enabled templated test for service_bluetooth_disabled#12211
Merged
Conversation
|
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
|
Code Climate has analyzed commit 2234dcc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
Mab879
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Disable test scenario that tries to start bluetooth service and then expect it to fail.
Rationale:
The service is dependent on loaded
btusbkernel module. However, this module is not loaded by default and templated test scenario doesn't load it either.We had similar problem in the past #11949 and now it started happening also on RHEL 8.8 and 9.2. I tried it manually on those systems and to properly start the service, I had to
modprobe btusb(https://wiki.archlinux.org/title/Bluetooth#Installation). It will be better to disable the test scenario completely rather than creating Contest waiver.Review Hints:
Try Automatus for
service_bluetooth_disabledand see what test scenarios are not run.