Add package_firewalld_installed to CCN and enable CCN Advanced profile test in CI#12139
Conversation
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
To enable and configure firewalld, the package containing it must be installed.
|
Code Climate has analyzed commit dbb2c78 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
package_firewalld_installed to CCN and enable CCN Advanced profile test in CI
Description:
During testing of CCN profile in CI, Ansible playbook fatal error got discovered caused by missing firewalld - https://artifacts.dev.testing-farm.io/580411a3-6359-4b79-aea3-917376355d7a/#artifacts-/hardening/host-os/ansible/ccn_advanced (for fatal error, see https://artifacts.dev.testing-farm.io/580411a3-6359-4b79-aea3-917376355d7a/work-ccn_advanced7b8m02tc/hardening/host-os/ansible/ccn_advanced/execute/data/guest/default-0/hardening/host-os/ansible/ccn_advanced-1/output.txt)
With
package_firewalld_installed(which seems reasonable to be part ofThe System Has an Activated Local Firewallrequirement), everything is fine.Now, when CCN Advanced playbook passes on Centos Stream 9, it can be enabled in CI.
Rationale:
Fix for cases when firewalld is not installed by default + increase test coverage in CI.
Review Hints:
See Testing Farm results for CCN Advanced profile (the profile is RHEL9 only).