Add ansible remediation for no_tmux_in_shells rule#12138
Conversation
|
Hi @mrkanon. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
|
This datastream diff is auto generated by the check Click here to see the full diffNew data stream adds ansible remediation for rule 'xccdf_org.ssgproject.content_rule_no_tmux_in_shells'. |
|
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
Mab879
left a comment
There was a problem hiding this comment.
Thanks for the PR. I just have one minor comment.
| # disruption = low | ||
|
|
||
| - name: {{{ rule_title }}} - Ensure tmux line not exists in /etc/shells | ||
| ansible.builtin.lineinfile: |
There was a problem hiding this comment.
Per the style guide please use 4 spaces in new YAML files.
There was a problem hiding this comment.
i updated the solution, thanks for the review
For no_tmux_in_shells rule Signed-off-by: Armando Acosta <armando.acosta@oracle.com>
c8cf648 to
30ffb33
Compare
|
Code Climate has analyzed commit 30ffb33 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
|
Waving Automatus tests as they pass locally. |
Description:
Add ansible remediation for
no_tmux_in_shellsruleRationale:
In the task filling gaps in OL9 automation, the rule no_tmux_in_shells has a remediation deficit with ansible. The parameters was taken of bash remediation