Skip to content

remove logind_session_timeout from stig_gui profiles#12086

Merged
Mab879 merged 3 commits into
ComplianceAsCode:masterfrom
vojtapolasek:remove_logind_session_timeout_from_stig_gui
Jul 2, 2024
Merged

remove logind_session_timeout from stig_gui profiles#12086
Mab879 merged 3 commits into
ComplianceAsCode:masterfrom
vojtapolasek:remove_logind_session_timeout_from_stig_gui

Conversation

@vojtapolasek
Copy link
Copy Markdown
Collaborator

@vojtapolasek vojtapolasek commented Jun 21, 2024

Description:

  • deselect the rule in stig_gui profiles for rhel8, rhel9m, rhel10 products
  • add explaining comment
  • remove rhel8 stigid from the rule as it is static

Rationale:

  • it was agreed that mechanism for locking of idle sessions is handled well enough by Gnome screensaver in the case of GUI profiles, the rule was worsening user experience in this case

Review Hints:

  • review list of rules in stig_gui profiles

@vojtapolasek vojtapolasek added RHEL9 Red Hat Enterprise Linux 9 product related. Update Profile Issues or pull requests related to Profiles updates. RHEL8 Red Hat Enterprise Linux 8 product related. STIG STIG Benchmark related. RHEL10 Red Hat Enterprise Linux 10 product related. labels Jun 21, 2024
@vojtapolasek vojtapolasek added this to the 0.1.74 milestone Jun 21, 2024
@vojtapolasek vojtapolasek requested a review from a team as a code owner June 21, 2024 14:46
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 21, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 21, 2024 •
edited
Loading

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12086
This image was built from commit: 1ae9b39

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12086

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12086 make deploy-local

@Mab879 Mab879 self-assigned this Jun 21, 2024
Mab879
Mab879 requested changes Jun 21, 2024
View reviewed changes
Comment thread linux_os/guide/system/accounts/accounts-physical/logind_session_timeout/rule.yml
@vojtapolasek vojtapolasek force-pushed the remove_logind_session_timeout_from_stig_gui branch from e0dbb23 to 1ae9b39 Compare July 2, 2024 10:51
@vojtapolasek
Copy link
Copy Markdown
Collaborator Author

vojtapolasek commented Jul 2, 2024

Great observation, I updated the PR.

@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented Jul 2, 2024

Code Climate has analyzed commit 1ae9b39 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 merged commit 6bdb083 into ComplianceAsCode:master Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels

RHEL8 Red Hat Enterprise Linux 8 product related. RHEL9 Red Hat Enterprise Linux 9 product related. RHEL10 Red Hat Enterprise Linux 10 product related. STIG STIG Benchmark related. Update Profile Issues or pull requests related to Profiles updates.

Projects

None yet

Milestone

0.1.74

Development

Successfully merging this pull request may close these issues.

2 participants

@vojtapolasek @Mab879