Skip to content

CMP-2457: PCI-DSS v4 Requirement 5#12045

Merged
rhmdnd merged 3 commits into
ComplianceAsCode:masterfrom
yuumasato:pcidss_4_req_5
Jun 20, 2024
Merged

CMP-2457: PCI-DSS v4 Requirement 5#12045
rhmdnd merged 3 commits into
ComplianceAsCode:masterfrom
yuumasato:pcidss_4_req_5

Conversation

@yuumasato
Copy link
Copy Markdown
Member

@yuumasato yuumasato commented Jun 3, 2024

Description:

  • Good part of Requirement 5 is not applicable
  • While we could add some rules and checks for anti-malware solutions, it will likely not completely satisfy the requirement, and will largely depend on the deployment parameters.

@yuumasato yuumasato added OpenShift OpenShift product related. pci-dss labels Jun 3, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2024 •
edited
Loading

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12045
This image was built from commit: dee8b59

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12045

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12045 make deploy-local

rhmdnd
rhmdnd reviewed Jun 3, 2024
View reviewed changes
Comment thread controls/pcidss_4_ocp4.yml
rhmdnd
rhmdnd reviewed Jun 3, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Just one question inline.

rhmdnd
rhmdnd approved these changes Jun 5, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yuumasato
Copy link
Copy Markdown
Member Author

yuumasato commented Jun 7, 2024

Just rebased to address the product stability test.

@xiaojiey
Copy link
Copy Markdown
Collaborator

xiaojiey commented Jun 7, 2024

/lgtm

@xiaojiey
Copy link
Copy Markdown
Collaborator

xiaojiey commented Jun 7, 2024

/test 4.14-images

@rhmdnd
Copy link
Copy Markdown
Collaborator

rhmdnd commented Jun 7, 2024

Seems to be failing for RHEL 10 builds?

yuumasato added 3 commits June 13, 2024 11:23
@yuumasato
CMP-2457: Requirement 5.1 is not applicable
9ef986a 
Documenting processess and mechanisms is not in scope for OCP.
@yuumasato
CPM-2457: Requirement 5.2 and 5.3 are not automated
b7f7daa 
There are multiple ways to prevent, or detect, and address malicious software.
@yuumasato
CPM-2457: Requirement 5.4 is not applicable
dee8b59
@yuumasato
Copy link
Copy Markdown
Member Author

yuumasato commented Jun 13, 2024

Rebased on latest master

@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented Jun 13, 2024

Code Climate has analyzed commit dee8b59 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@marcusburghardt
Copy link
Copy Markdown
Member

marcusburghardt commented Jun 17, 2024

/packit retest

rhmdnd
rhmdnd approved these changes Jun 20, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rhmdnd rhmdnd merged commit d5f51e9 into ComplianceAsCode:master Jun 20, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone Jun 20, 2024
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Jun 20, 2024
@yuumasato yuumasato deleted the pcidss_4_req_5 branch June 21, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-cerny jan-cerny jan-cerny left review comments

@rhmdnd rhmdnd rhmdnd approved these changes

Assignees

@rhmdnd rhmdnd

Labels

OpenShift OpenShift product related. pci-dss Update Profile Issues or pull requests related to Profiles updates.

Projects

None yet

Milestone

0.1.74

Development

Successfully merging this pull request may close these issues.

6 participants

@yuumasato @xiaojiey @rhmdnd @marcusburghardt @jan-cerny @Mab879