Skip to content

[Stabilization]: Ensure that security_patches_up_to_date is not built with remediations#11993

Merged
jan-cerny merged 1 commit into
ComplianceAsCode:stabilization-v0.1.73from
vojtapolasek:rhel_remove_remediation_for_security_patches_up_to_date
May 14, 2024
Merged

[Stabilization]: Ensure that security_patches_up_to_date is not built with remediations#11993
jan-cerny merged 1 commit into
ComplianceAsCode:stabilization-v0.1.73from
vojtapolasek:rhel_remove_remediation_for_security_patches_up_to_date

Conversation

@vojtapolasek
Copy link
Copy Markdown
Collaborator

@vojtapolasek vojtapolasek commented May 14, 2024

Description:

  • modify list of supported platforms for Ansible and Bash remediations for security_patches_up_to_date

Rationale:

  • the rule is being phased out of RH products

Review Hints:

  • build the content and ensure that remediations are not present in the resulting content, e.g. playbooks etc

@vojtapolasek vojtapolasek added RHEL Red Hat Enterprise Linux product related. Ansible Ansible remediation update. Bash Bash remediation update. Update Rule Issues or pull requests related to Rules updates. labels May 14, 2024
@vojtapolasek vojtapolasek added this to the 0.1.73 milestone May 14, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2024 •
edited
Loading

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11993
This image was built from commit: 1368a76

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11993

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11993 make deploy-local

jan-cerny
jan-cerny reviewed May 14, 2024
View reviewed changes
Comment thread linux_os/guide/system/software/updating/security_patches_up_to_date/ansible/shared.yml Outdated
@@ -1,4 +1,4 @@
# platform = multi_platform_all
# platform = multi_platform_alinux_multi_platform_anolis,multi_platform_fedora,multi_platform_ol,multi_platform_sle,multi_platform_ubuntu,multi_platform_uos
Copy link
Copy Markdown
Collaborator

@jan-cerny jan-cerny May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be a comma instead of underscore after alinux

Copy link
Copy Markdown
Collaborator Author

@vojtapolasek vojtapolasek May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, fixed.

@vojtapolasek vojtapolasek force-pushed the rhel_remove_remediation_for_security_patches_up_to_date branch from b1feec9 to 1368a76 Compare May 14, 2024 12:32
@jan-cerny jan-cerny merged commit 2bf9d43 into ComplianceAsCode:stabilization-v0.1.73 May 14, 2024
@jan-cerny
Copy link
Copy Markdown
Collaborator

jan-cerny commented May 14, 2024

The SRG mapping fail is expected because the stabilization branch doesn't build the rhel10 product.

@vojtapolasek vojtapolasek mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels

Ansible Ansible remediation update. Bash Bash remediation update. RHEL Red Hat Enterprise Linux product related. Update Rule Issues or pull requests related to Rules updates.

Projects

None yet

Milestone

0.1.73

Development

Successfully merging this pull request may close these issues.

2 participants

@vojtapolasek @jan-cerny