Skip to content

Fix missing variable for Ubuntu 22.04#11973

Merged
dodys merged 1 commit into
ComplianceAsCode:masterfrom
mpurg:ubuntu_2204_stig_651020
May 8, 2024
Merged

Fix missing variable for Ubuntu 22.04#11973
dodys merged 1 commit into
ComplianceAsCode:masterfrom
mpurg:ubuntu_2204_stig_651020

Conversation

@mpurg
Copy link
Copy Markdown
Contributor

@mpurg mpurg commented May 8, 2024

Description:

  • Define variable aide_default_path for Ubuntu 22.04

Rationale:

  • If not defined, it breaks rule aide_disable_silentreports.

@mpurg
Fix missing variable for Ubuntu 22.04
e041c97 
Variable `aide_default_path` was not defined, breakin
rule `aide_disable_silentreports`.
@mpurg mpurg requested a review from a team as a code owner May 8, 2024 13:29
@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label May 8, 2024
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 8, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@dodys dodys self-assigned this May 8, 2024
@dodys dodys added Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates. and removed Update Profile Issues or pull requests related to Profiles updates. labels May 8, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11973
This image was built from commit: e041c97

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11973

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11973 make deploy-local

@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented May 8, 2024

Code Climate has analyzed commit e041c97 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

dodys
dodys approved these changes May 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 69487ac into ComplianceAsCode:master May 8, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone May 8, 2024
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label May 8, 2024
@evgenyz evgenyz mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels

needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.

Projects

None yet

Milestone

0.1.74

Development

Successfully merging this pull request may close these issues.

3 participants

@mpurg @dodys @Mab879