Skip to content

Override few variables for Ubuntu 22.04#11928

Merged
dodys merged 8 commits into
ComplianceAsCode:masterfrom
mpurg:ubuntu_2204_var_overrides
May 6, 2024
Merged

Override few variables for Ubuntu 22.04#11928
dodys merged 8 commits into
ComplianceAsCode:masterfrom
mpurg:ubuntu_2204_var_overrides

Conversation

@mpurg
Copy link
Copy Markdown
Contributor

@mpurg mpurg commented May 2, 2024

Description:

Override several variables to match package/service/user names on Ubuntu 22.04.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label May 2, 2024
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 2, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2024 •
edited
Loading

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11928
This image was built from commit: d12d4ab

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11928

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11928 make deploy-local

@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented May 2, 2024

Code Climate has analyzed commit d12d4ab and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@dodys dodys requested a review from a team May 6, 2024 07:56
@dodys dodys self-assigned this May 6, 2024
@dodys dodys added Ubuntu Ubuntu product related. ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels May 6, 2024
dodys
dodys approved these changes May 6, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 83d2d75 into ComplianceAsCode:master May 6, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone May 6, 2024
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels

ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Rule Issues or pull requests related to Rules updates.

Projects

None yet

Milestone

0.1.74

Development

Successfully merging this pull request may close these issues.

3 participants

@mpurg @dodys @Mab879