Revert changes to no_empty_passwords for Ubuntu#11918
Conversation
|
Hi @mpurg. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
|
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
dodys
left a comment
There was a problem hiding this comment.
test is failing, some shellcheck issue
In PR#11282, the check for STIG rule UBTU-20-010463 (`no_empty_passwords`) was modified to also remove nullok from common-auth. A new version of STIG has since been released, not including the proposed change, thus we are reverting the change in the check logic.
5a0d142 to
8eea7c9
Compare
|
@dodys fixed |
|
Code Climate has analyzed commit 8eea7c9 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
|
/packit build |
Description:
no_empty_passwords)Rationale:
no_empty_passwords) was modified to also remove nullok from common-auth. A new version of STIG has since been released, not including the proposed change, thus we are reverting the change in the check logic.