Skip to content

Fix SCE checks for iptables_loopback_traffic#11850

Merged
dodys merged 1 commit into
ComplianceAsCode:masterfrom
mpurg:ubuntu_fix_sce_loopback
Apr 18, 2024
Merged

Fix SCE checks for iptables_loopback_traffic#11850
dodys merged 1 commit into
ComplianceAsCode:masterfrom
mpurg:ubuntu_fix_sce_loopback

Conversation

@mpurg
Copy link
Copy Markdown
Contributor

@mpurg mpurg commented Apr 18, 2024

Description:

  • Fix for SCE check for set_loopback_traffic and set_ipv6_loopback_traffic

Rationale:

@mpurg
Fix SCE checks for iptables_loopback_traffic
f7208ed 
The checks failed when the counters in iptables were large
enough and were formatted to human readable format (K, M).

Fixes https://bugs.launchpad.net/usg/+bug/2061215
@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 18, 2024
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 18, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 18, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 18, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11850
This image was built from commit: f7208ed

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11850

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11850 make deploy-local

@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented Apr 18, 2024

Code Climate has analyzed commit f7208ed and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.2% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt requested a review from dodys April 18, 2024 08:17
@marcusburghardt marcusburghardt added the Ubuntu Ubuntu product related. label Apr 18, 2024
@dodys dodys self-assigned this Apr 18, 2024
@dodys dodys added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Apr 18, 2024
dodys
dodys approved these changes Apr 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 4db4614 into ComplianceAsCode:master Apr 18, 2024
@Mab879 Mab879 added this to the 0.1.73 milestone Apr 18, 2024
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels

ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Rule Issues or pull requests related to Rules updates.

Projects

None yet

Milestone

0.1.73

Development

Successfully merging this pull request may close these issues.

4 participants

@mpurg @dodys @Mab879 @marcusburghardt