Skip to content

Modify rule file_groupowner_system_journal#11836

Merged
dodys merged 1 commit into
ComplianceAsCode:masterfrom
mpurg:ubuntu_2204_stig_232095
May 7, 2024
Merged

Modify rule file_groupowner_system_journal#11836
dodys merged 1 commit into
ComplianceAsCode:masterfrom
mpurg:ubuntu_2204_stig_232095

Conversation

@mpurg
Copy link
Copy Markdown
Contributor

@mpurg mpurg commented Apr 17, 2024

Description:

Modified rule file_groupowner_system_journal to comply with UBTU-22-232095 (systemd-journal must be group-owner of files in /var/log/journal/...)

@mpurg mpurg requested a review from a team as a code owner April 17, 2024 08:17
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 17, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 17, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 17, 2024

Start a new ephemeral environment with changes proposed in this pull request:

ocp4 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 17, 2024 •
edited
Loading

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11836
This image was built from commit: 799086c

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11836

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11836 make deploy-local

@dodys dodys self-assigned this Apr 17, 2024
@dodys dodys added Ubuntu Ubuntu product related. ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. and removed needs-ok-to-test Used by openshift-ci bot. labels Apr 17, 2024
@mpurg mpurg force-pushed the ubuntu_2204_stig_232095 branch from 0ece8e6 to 7127c5a Compare April 29, 2024 07:52
dodys
dodys approved these changes Apr 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@mpurg mpurg force-pushed the ubuntu_2204_stig_232095 branch from 7127c5a to 30a8cd7 Compare May 6, 2024 14:09
@dodys
Copy link
Copy Markdown
Contributor

dodys commented May 7, 2024

/packit test

@dodys
Copy link
Copy Markdown
Contributor

dodys commented May 7, 2024

/packit build

@mpurg
Modify rule file_groupowner_system_journal
799086c 
Modified rule `file_groupowner_system_journal` to comply
with UBTU-22-232095 (systemd-journal must be group-owner
of files in /var/log/journal/...)
@mpurg mpurg force-pushed the ubuntu_2204_stig_232095 branch from 30a8cd7 to 799086c Compare May 7, 2024 09:05
@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented May 7, 2024

Code Climate has analyzed commit 799086c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@dodys dodys merged commit ac1089e into ComplianceAsCode:master May 7, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone May 7, 2024
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels

ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. Ubuntu Ubuntu product related. Update Rule Issues or pull requests related to Rules updates.

Projects

None yet

Milestone

0.1.74

Development

Successfully merging this pull request may close these issues.

3 participants

@mpurg @dodys @Mab879