Changes in template service_disabled - ansible part#11645
Conversation
|
Hi @rumch-se. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
|
Hello @marcusburghardt I decided to make the code more simple and clear. I used as reference the code of the template socket.disable. Have a nice day |
|
Hello @marcusburghardt |
|
Code Climate has analyzed commit f00e0ae and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.8% (0.0% change). View more on Code Climate. |
Description:
Rationale:
At the moment the current ansible template:
does not check if the service exists and there are cases when it tries to disable services which are not exists. Because of that we have a fatal error like this - when we want to disable for example the service zebra via the rule "service_zebra_disabled"
TASK [Disable service zebra] ********************************************************************************************************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Could not find the requested service zebra.service: host"}
[WARNING]: noop task does not support when conditional
uses values "yes" and "no" for attributes which according the official ansible documentation are boolean and they have to be true or false