Skip to content

oauth_or_oauthclient_token_maxage: Use variable for remediation of rule#11603

Merged
rhmdnd merged 1 commit into
ComplianceAsCode:masterfrom
yuumasato:parametrize_remediation_oauth_or_oauthclient_token_maxage
Feb 21, 2024
Merged

oauth_or_oauthclient_token_maxage: Use variable for remediation of rule#11603
rhmdnd merged 1 commit into
ComplianceAsCode:masterfrom
yuumasato:parametrize_remediation_oauth_or_oauthclient_token_maxage

Conversation

@yuumasato
Copy link
Copy Markdown
Member

@yuumasato yuumasato commented Feb 19, 2024

Description:

  • As the rule is parametrized to use a variable, the check should use it for remediation.

Rationale:

Review Hints:

@yuumasato
Use variable for remediation of rule
40817e9 
The rule's extended definition checks are leveragin the variable for the
check, so the remediation should also use it.
@yuumasato yuumasato added OpenShift OpenShift product related. Update Rule Issues or pull requests related to Rules updates. labels Feb 19, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 19, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented Feb 19, 2024

Code Climate has analyzed commit 40817e9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.3% (0.0% change).

View more on Code Climate.

@rhmdnd
Copy link
Copy Markdown
Collaborator

rhmdnd commented Feb 19, 2024

/test

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 19, 2024

@rhmdnd: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test 4.13-e2e-aws-ocp4-cis
  • /test 4.13-e2e-aws-ocp4-cis-node
  • /test 4.13-e2e-aws-ocp4-e8
  • /test 4.13-e2e-aws-ocp4-high
  • /test 4.13-e2e-aws-ocp4-high-node
  • /test 4.13-e2e-aws-ocp4-moderate
  • /test 4.13-e2e-aws-ocp4-moderate-node
  • /test 4.13-e2e-aws-ocp4-pci-dss
  • /test 4.13-e2e-aws-ocp4-pci-dss-node
  • /test 4.13-e2e-aws-ocp4-stig
  • /test 4.13-e2e-aws-ocp4-stig-node
  • /test 4.13-e2e-aws-rhcos4-e8
  • /test 4.13-e2e-aws-rhcos4-high
  • /test 4.13-e2e-aws-rhcos4-moderate
  • /test 4.13-e2e-aws-rhcos4-stig
  • /test 4.13-images
  • /test 4.14-images
  • /test 4.15-e2e-aws-ocp4-cis
  • /test 4.15-e2e-aws-ocp4-cis-node
  • /test 4.15-e2e-aws-ocp4-e8
  • /test 4.15-e2e-aws-ocp4-high
  • /test 4.15-e2e-aws-ocp4-high-node
  • /test 4.15-e2e-aws-ocp4-moderate
  • /test 4.15-e2e-aws-ocp4-moderate-node
  • /test 4.15-e2e-aws-ocp4-pci-dss
  • /test 4.15-e2e-aws-ocp4-pci-dss-node
  • /test 4.15-e2e-aws-ocp4-stig
  • /test 4.15-e2e-aws-ocp4-stig-node
  • /test 4.15-e2e-aws-rhcos4-e8
  • /test 4.15-e2e-aws-rhcos4-high
  • /test 4.15-e2e-aws-rhcos4-moderate
  • /test 4.15-e2e-aws-rhcos4-stig
  • /test 4.15-images
  • /test 4.16-e2e-aws-ocp4-cis
  • /test 4.16-e2e-aws-ocp4-cis-node
  • /test 4.16-e2e-aws-ocp4-e8
  • /test 4.16-e2e-aws-ocp4-high
  • /test 4.16-e2e-aws-ocp4-high-node
  • /test 4.16-e2e-aws-ocp4-moderate
  • /test 4.16-e2e-aws-ocp4-moderate-node
  • /test 4.16-e2e-aws-ocp4-pci-dss
  • /test 4.16-e2e-aws-ocp4-pci-dss-node
  • /test 4.16-e2e-aws-ocp4-stig
  • /test 4.16-e2e-aws-ocp4-stig-node
  • /test 4.16-e2e-aws-rhcos4-e8
  • /test 4.16-e2e-aws-rhcos4-high
  • /test 4.16-e2e-aws-rhcos4-moderate
  • /test 4.16-e2e-aws-rhcos4-stig
  • /test 4.16-images
  • /test e2e-aws-ocp4-cis
  • /test e2e-aws-ocp4-cis-node
  • /test e2e-aws-ocp4-e8
  • /test e2e-aws-ocp4-high
  • /test e2e-aws-ocp4-high-node
  • /test e2e-aws-ocp4-moderate
  • /test e2e-aws-ocp4-moderate-node
  • /test e2e-aws-ocp4-pci-dss
  • /test e2e-aws-ocp4-pci-dss-node
  • /test e2e-aws-ocp4-stig
  • /test e2e-aws-ocp4-stig-node
  • /test e2e-aws-rhcos4-e8
  • /test e2e-aws-rhcos4-high
  • /test e2e-aws-rhcos4-moderate
  • /test e2e-aws-rhcos4-stig
  • /test images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-ComplianceAsCode-content-master-4.13-images
  • pull-ci-ComplianceAsCode-content-master-4.14-images
  • pull-ci-ComplianceAsCode-content-master-4.15-images
  • pull-ci-ComplianceAsCode-content-master-4.16-images
  • pull-ci-ComplianceAsCode-content-master-images
Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhmdnd
Copy link
Copy Markdown
Collaborator

rhmdnd commented Feb 19, 2024

/test 4.13-e2e-aws-ocp4-moderate
/test 4.15-e2e-aws-ocp4-moderate
/test 4.16-e2e-aws-ocp4-moderate
/test e2e-aws-ocp4-moderate

@rhmdnd
Copy link
Copy Markdown
Collaborator

rhmdnd commented Feb 19, 2024

Change looks good to me. CI should confirm the remediation is working.

@yuumasato
Copy link
Copy Markdown
Member Author

yuumasato commented Feb 19, 2024

Thanks, I forgot to start the CI tets.

@yuumasato yuumasato added this to the 0.1.73 milestone Feb 19, 2024
@yuumasato yuumasato removed the Update Rule Issues or pull requests related to Rules updates. label Feb 19, 2024
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 19, 2024

@yuumasato: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.16-e2e-aws-ocp4-moderate 40817e9 link true /test 4.16-e2e-aws-ocp4-moderate

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rhmdnd
Copy link
Copy Markdown
Collaborator

rhmdnd commented Feb 19, 2024

The 4.16 failure is unrelated and being fixed in #11499

@rhmdnd rhmdnd merged commit 58b7bc1 into ComplianceAsCode:master Feb 21, 2024
@yuumasato yuumasato deleted the parametrize_remediation_oauth_or_oauthclient_token_maxage branch March 1, 2024 14:35
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhmdnd rhmdnd rhmdnd approved these changes

@Vincent056 Vincent056 Awaiting requested review from Vincent056

Assignees

@rhmdnd rhmdnd

Labels

OpenShift OpenShift product related. Update Rule Issues or pull requests related to Rules updates.

Projects

None yet

Milestone

0.1.73

Development

Successfully merging this pull request may close these issues.

3 participants

@yuumasato @rhmdnd @Mab879