Update sudo_dedicated_group#11586
Merged
Merged
Conversation
1. Fix broken test 2. Move to only forbidding root from owning the sudo binary
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit c7e7073 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.3% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Feb 14, 2024
Collaborator
jan-cerny
left a comment
There was a problem hiding this comment.
I have run the tests locally:
jcerny@fedora:~/work/git/scap-security-guide (pr/11586)$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel8 sudo_dedicated_group
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2024-02-14-1116/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_sudo_dedicated_group
INFO - Script no_group.fail.sh using profile (all) OK
INFO - Script other_group.pass.sh using profile (all) OK
INFO - Script root_default.fail.sh using profile (all) OK
jcerny@fedora:~/work/git/scap-security-guide (pr/11586)$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel8 --remediate-using ansible sudo_dedicated_group
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2024-02-14-1120/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_sudo_dedicated_group
INFO - Script no_group.fail.sh using profile (all) OK
INFO - Script other_group.pass.sh using profile (all) OK
INFO - Script root_default.fail.sh using profile (all) OK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
Update ANSSI