Review CIS RHEL8 v3.0.0 Section 3#11469
Conversation
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
marcusburghardt
left a comment
There was a problem hiding this comment.
Thanks for the update @Mab879 . I have some minor comments about titles and some considerations about references.
| - l1_workstation | ||
| status: automated | ||
| rules: | ||
| - set_firewalld_default_zone |
There was a problem hiding this comment.
We should remove the cis@rhel8 references on these rules no longer mentioned in the control file.
There was a problem hiding this comment.
Unfortunately I can still see cis@rhel8: references in rule no longer mentioned in control file.
Basically are rules removed by this commit 8f140f6
We can try to clean-up this after, but doing it now would be good.
marcusburghardt
left a comment
There was a problem hiding this comment.
It is almost ready except for few more issues related to references. They could even be fixed in another smaller PR without problem, but unfortunately the profile stability test is also failing so we can't merge it.
…d for RHEL 8 CIS Closes ComplianceAsCode#5246
34cb367 to
908eb8a
Compare
|
Code Climate has analyzed commit 908eb8a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.5% (0.0% change). View more on Code Climate. |
marcusburghardt
left a comment
There was a problem hiding this comment.
Great. Thanks @Mab879
Description:
Review the cis_rhel8.yml control file and update section 3 networking in alignment to CIS RHEL 8 v3.0.0.
Rationale:
Keep RHEL 8 profiles updated with CIS RHEL 8 last version.