Skip to content

add XSLT_PATH prefix with environment override#11390

Merged
jan-cerny merged 1 commit into
ComplianceAsCode:masterfrom
VCTLabs:template-prefix
Dec 18, 2023
Merged

add XSLT_PATH prefix with environment override#11390
jan-cerny merged 1 commit into
ComplianceAsCode:masterfrom
VCTLabs:template-prefix

Conversation

@sarnold
Copy link
Copy Markdown
Contributor

@sarnold sarnold commented Dec 17, 2023

Description:

  • split hard-coded path string into default /usr prefix and relative install path
  • use XSLT_PREFIX environment variable to override prefix

Rationale:

  • allows development workflows using a virtual environment for installed dependencies

Review Hints:

  • see tox example here

@sarnold
add template path prefix with environment override
96ad35b 
* this allows generate_guides.py to run inside a virtual or packaging
  environment

Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>
@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 17, 2023
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 17, 2023

Hi @sarnold. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 17, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented Dec 17, 2023

Code Climate has analyzed commit 96ad35b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Dec 18, 2023
@jan-cerny jan-cerny added this to the 0.1.72 milestone Dec 18, 2023
@jan-cerny jan-cerny added the Infrastructure Our content build system label Dec 18, 2023
@jan-cerny jan-cerny merged commit ec32d9f into ComplianceAsCode:master Dec 18, 2023
@sarnold sarnold deleted the template-prefix branch February 5, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels

Infrastructure Our content build system needs-ok-to-test Used by openshift-ci bot.

Projects

None yet

Milestone

0.1.72

Development

Successfully merging this pull request may close these issues.

2 participants

@sarnold @jan-cerny