Remove bogus specifier from audit_rules_privileged_commands_unix2_chkpwd#11379
Merged
Merged
Conversation
rule's template This sle15 specifier is redundant and goes against the build system rules.
|
Code Climate has analyzed commit 42b9a7a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.5% (0.0% change). View more on Code Climate. |
marcusburghardt
approved these changes
Dec 13, 2023
Member
marcusburghardt
left a comment
There was a problem hiding this comment.
The rule is only used by sle15 and this would be updated if the rule would adopted by other products. But the specifier is indeed not necessary now.
Member
|
Automatus tests for CS8 and CS9 are failing because the rule is restricted to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This
sle15specifier is redundant and goes against the build system rules.Rationale:
In a situation when rule's
prodtypewould be expanded build will fail.