Remove timer_logrotate_enabled from some pci-dss profiles#11349
Merged
Mab879 merged 3 commits intoDec 5, 2023
Merged
Conversation
although the rule has rhel7 and rhel8 prodtype, it does not make sense on those products
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
|
This datastream diff is auto generated by the check Click here to see the full diffNew content has different text for rule 'xccdf_org.ssgproject.content_rule_timer_logrotate_enabled'.
--- xccdf_org.ssgproject.content_rule_timer_logrotate_enabled
+++ xccdf_org.ssgproject.content_rule_timer_logrotate_enabled
@@ -5,6 +5,9 @@
[description]:
The logrotate timer can be enabled with the following command:
$ sudo systemctl enable logrotate.timer
+
+[warning]:
+The Systemd unit logrotate.timer does not exist in Red Hat Enterprise Linux 8. The rule ensure_logrotate_activated is suggested instead.
[reference]:
BP28(R71) |
3cce4ea to
147b1fc
Compare
|
Code Climate has analyzed commit 147b1fc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.5%. View more on Code Climate. |
Collaborator
|
/packit retest-failed |
Member
|
Waving the automatus failure as it is expected since the service doesn't exist on CentOS Stream 8. |
Mab879
approved these changes
Dec 5, 2023
Member
|
/packit retest-failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #11348 but this PR is against master.