Skip to content

Fix kernel_module_disabled template for Ubuntu#11294

Merged
dodys merged 1 commit into
ComplianceAsCode:masterfrom
mpurg:fix_ubuntu_kernel_module_disabled
Nov 21, 2023
Merged

Fix kernel_module_disabled template for Ubuntu#11294
dodys merged 1 commit into
ComplianceAsCode:masterfrom
mpurg:fix_ubuntu_kernel_module_disabled

Conversation

@mpurg
Copy link
Copy Markdown
Contributor

@mpurg mpurg commented Nov 21, 2023

Description:

  • Fix kernel_module_disabled template oval and tests to check for blacklisted modules in Ubuntu

Rationale:

PR #11062 included blacklisting of kernel modules in Ubuntu, as prescribed by rule STIG UBTU-20-010461
and analogous rules in latest CIS benchmarks (20.04 v2.0.1 and 22.04 v1.0.0), but failed to include
changes to OVAL and tests.

@mpurg
Fix kernel_module_disabled template for Ubuntu
9d4e4aa 
- oval and tests did not check for blacklisted modules
@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 21, 2023
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Nov 21, 2023

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 21, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented Nov 21, 2023

Code Climate has analyzed commit 9d4e4aa and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.8%.

View more on Code Climate.

@dodys dodys requested a review from a team November 21, 2023 15:36
@dodys dodys added Ubuntu Ubuntu product related. ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. and removed needs-ok-to-test Used by openshift-ci bot. labels Nov 21, 2023
@dodys
Copy link
Copy Markdown
Contributor

dodys commented Nov 21, 2023

/packit retest-failed

@dodys dodys added the CIS CIS Benchmark related. label Nov 21, 2023
dodys
dodys approved these changes Nov 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@dodys dodys merged commit d9989c0 into ComplianceAsCode:master Nov 21, 2023
@Mab879 Mab879 added this to the 0.1.71 milestone Nov 27, 2023
@Mab879 Mab879 added the OVAL OVAL update. Related to the systems assessments. label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels

CIS CIS Benchmark related. ok-to-test Used by openshift-ci bot. OVAL OVAL update. Related to the systems assessments. STIG STIG Benchmark related. Ubuntu Ubuntu product related.

Projects

None yet

Milestone

0.1.71

Development

Successfully merging this pull request may close these issues.

3 participants

@mpurg @dodys @Mab879