Skip to content

Enable PCI-DSS in test-farm tests#11257

Merged
mildas merged 1 commit into
ComplianceAsCode:masterfrom
marcusburghardt:pcidss_ci_tests
Nov 9, 2023
Merged

Enable PCI-DSS in test-farm tests#11257
mildas merged 1 commit into
ComplianceAsCode:masterfrom
marcusburghardt:pcidss_ci_tests

Conversation

@marcusburghardt
Copy link
Copy Markdown
Member

@marcusburghardt marcusburghardt commented Nov 8, 2023

Description:

We want in increase the adoption of pcidss_4 control file.
This control file is more agnostic to products and therefore more collaboration on it is expected.
It is good to include profile tests in Upstream in order to detect any possible issue as earlier as possible.

Rationale:

  • Complement CI tests to find eventual issues earlier.

@marcusburghardt marcusburghardt added the Test Suite Update in Test Suite. label Nov 8, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 8, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@mildas
Copy link
Copy Markdown
Contributor

mildas commented Nov 8, 2023

PCI DSS tests are running (see TF tests). However, they are failing in Ansible test in rpm_verify_hashes. I've proposed a change for the downstream test - https://src.fedoraproject.org/tests/scap-security-guide/pull-request/45
@marcusburghardt please check the PR. When it gets merged, we can re-run.

@mildas mildas self-assigned this Nov 8, 2023
@marcusburghardt
Copy link
Copy Markdown
Member Author

marcusburghardt commented Nov 9, 2023

PCI DSS tests are running (see TF tests). However, they are failing in Ansible test in rpm_verify_hashes. I've proposed a change for the downstream test - https://src.fedoraproject.org/tests/scap-security-guide/pull-request/45 @marcusburghardt please check the PR. When it gets merged, we can re-run.

It worked @mildas . Thanks

@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented Nov 9, 2023

Code Climate has analyzed commit 72bc715 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.8%.

View more on Code Climate.

@marcusburghardt
Copy link
Copy Markdown
Member Author

marcusburghardt commented Nov 9, 2023

Gate (AR / RHEL) / Build, Lint Ansible Roles on Fedora Latest (Container) (pull_request) failure is not related to this PR.

@mildas mildas merged commit 053350f into ComplianceAsCode:master Nov 9, 2023
@marcusburghardt marcusburghardt deleted the pcidss_ci_tests branch November 9, 2023 15:06
This was referenced Nov 10, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mildas mildas mildas approved these changes

Assignees

@mildas mildas

Labels

Test Suite Update in Test Suite.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcusburghardt @mildas