Skip to content

remove sle15 from package_samba_common_installed#11231

Merged
teacup-on-rockingchair merged 1 commit into
ComplianceAsCode:masterfrom
Whidix:update-package_samba_common_installed
Nov 2, 2023
Merged

remove sle15 from package_samba_common_installed#11231
teacup-on-rockingchair merged 1 commit into
ComplianceAsCode:masterfrom
Whidix:update-package_samba_common_installed

Conversation

@Whidix
Copy link
Copy Markdown
Contributor

@Whidix Whidix commented Oct 30, 2023

Description:

remove sle15 from package_samba_common_installed since samba-common doesn't exist on sles

@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Oct 30, 2023
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 30, 2023

Hi @Whidix. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 30, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented Oct 30, 2023

Code Climate has analyzed commit b631653 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.4%.

View more on Code Climate.

@Mab879 Mab879 requested a review from a team October 30, 2023 18:20
teacup-on-rockingchair
teacup-on-rockingchair approved these changes Nov 2, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 🙇

@teacup-on-rockingchair teacup-on-rockingchair merged commit 804f155 into ComplianceAsCode:master Nov 2, 2023
@jan-cerny jan-cerny added this to the 0.1.71 milestone Nov 2, 2023
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teacup-on-rockingchair teacup-on-rockingchair teacup-on-rockingchair approved these changes

Assignees

@teacup-on-rockingchair teacup-on-rockingchair

Labels

needs-ok-to-test Used by openshift-ci bot. Update Rule Issues or pull requests related to Rules updates.

Projects

None yet

Milestone

0.1.71

Development

Successfully merging this pull request may close these issues.

4 participants

@Whidix @teacup-on-rockingchair @Mab879 @jan-cerny