Skip to content

Minor fix for pam_faillock regex on Ubuntu (5.4.2)#11205

Merged
dodys merged 1 commit into
ComplianceAsCode:masterfrom
mpurg:pam_faillock_regex
Oct 17, 2023
Merged

Minor fix for pam_faillock regex on Ubuntu (5.4.2)#11205
dodys merged 1 commit into
ComplianceAsCode:masterfrom
mpurg:pam_faillock_regex

Conversation

@mpurg
Copy link
Copy Markdown
Contributor

@mpurg mpurg commented Oct 16, 2023

Description:

Fixed regex to allow trailing whitespaces and comments

Rationale:

Review Hints:

@mpurg
Minor fix for pam_faillock regex on Ubuntu (5.4.2)
e605913 
- Fixed to allow trailing whitespaces and comments.
@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Oct 16, 2023
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 16, 2023

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 16, 2023

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@dodys dodys requested a review from a team October 17, 2023 09:52
@dodys dodys added Ubuntu Ubuntu product related. ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Oct 17, 2023
@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented Oct 17, 2023

Code Climate has analyzed commit e605913 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 57.0%.

View more on Code Climate.

dodys
dodys approved these changes Oct 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit ff6e2c7 into ComplianceAsCode:master Oct 17, 2023
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Oct 17, 2023
@Mab879 Mab879 added this to the 0.1.71 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels

ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Rule Issues or pull requests related to Rules updates.

Projects

None yet

Milestone

0.1.71

Development

Successfully merging this pull request may close these issues.

Set Lockouts for Failed Password Attempts - False Positives

3 participants

@mpurg @dodys @Mab879