Add Better a Error Message For Undefined Reference Types#11159
Merged
jan-cerny merged 1 commit intoOct 6, 2023
Conversation
This commit ensure that user is given a better error message if they add a reference type that the project doesn't know about.
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit 9b74309 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 56.9%. View more on Code Climate. |
jan-cerny
reviewed
Oct 2, 2023
Collaborator
jan-cerny
left a comment
There was a problem hiding this comment.
I like the change very much. I have reproduced the error. But I think we should do the same change also for "identifiers".
Member
Author
|
After a quick test it seems that we don't validate what identifiers like we do references. I feel that adding this behavior should be done on another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR improves the handling of undefined reference types by adding a better error message. This also fixes exception in the message text since
selfwas not defined.Rationale:
selfis not definedReview Hints:
cci) to your favorite rule