Provide option for the server to ignore the host header when generating identifiers - #1979
Merged
Conversation
TallTed
suggested changes
Jan 23, 2025
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
This provides a new option so the server ignores the host header when generating an identifier. Normally, the server would reject any requests that are not contained by the
--baseUrlparameter. This can sometimes be a nuisance when doing some initial development work when you want to access the server both internally and externally. Warnings will be logged when this option is enabled.