This repository was archived by the owner on Apr 15, 2024. It is now read-only.
[FAB-37] Campaign Import Export commands - #279
Merged
Merged
Conversation
| "@hapi/joi": "17.1.1", | ||
| "boxen": "4.2.0", | ||
| "chalk": "4.0.0", | ||
| "form-data": "3.0.0", |
| }); | ||
| } | ||
|
|
||
| importCampaign(projectId, token, filepath, deploy, overwrite) { |
Contributor
There was a problem hiding this comment.
We typically just POST file data ?? Why are we using multipart here ?
Collaborator
Author
There was a problem hiding this comment.
With streaming file, import API was throwing Unsupported Content Type error. This API expect form data. cURL examples https://docs.google.com/document/d/1RJwLVsFeYpHu1sDfhztLnnEcJ6iIu_yDFfjZmEu_2cc/edit
| printSuccess, printError, filterObject, parseObject, printTable, | ||
| } = require('./utils'); | ||
|
|
||
| module.exports.CreateMissionCommand = class CreateMissionCommand { |
Contributor
There was a problem hiding this comment.
Need to confirm we are supporting import/export of missions ?
Collaborator
Author
There was a problem hiding this comment.
AMP Commands branch (from which this branch is created) is old (last updated 10th Nov). Should I remove mission related code from this PR?
ghost
requested a review
from lkrishna-cs
December 14, 2020 16:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged
AMP-Commandsbranch also, as these commands should go firstChecklist:
Please check you fulfill ALL of the relevant checkboxes
npm testand it passes