This repository was archived by the owner on Apr 15, 2024. It is now read-only.
Tweaks to error handling - #183
Merged
Merged
Conversation
cdraper-CS
reviewed
May 7, 2019
cdraper-CS
left a comment
Contributor
There was a problem hiding this comment.
It's a bit surprising that we 'resolve' the errors. Looks like content upload checks the success flag, but save and test connection don't. They probably should be modified.
Assuming we continue to resolve, we need to provide 'status' if we have it, and/or modify the error handling in content upload.
vadan-cs
pushed a commit
that referenced
this pull request
May 23, 2019
pmantaring-cs
pushed a commit
that referenced
this pull request
Jun 6, 2019
* CCF-9286: return instanceId in the message when promoting a snapshot … (#162) * CCF-9286: return instanceId in the message when promoting a snapshot to an environment that was being returned by the api response but not getting included in the cli response * updated message with review comments * fixing undefined error when promoting a snapshot to an environment, instanceId is under `response.message.instanceId` (#164) * Add agents list-snapshot-instances (#168) * Fix invalid query param on list snap instances (#170) * Update minor-compatible dependencies * Tweaks to error handling (#183) * Added npm publish to build.sh. (#190) * Ccf 11021 validate configure (#189) * Add validations for url, accounts, user, password * Fix messages * Add support for CORTEX_URI * Fixed per review comments, support - in URL, remove dead redundant code * Adds support for Graph, Profiles, and Experiments APIs (#180) * Revved generator version and cli version. * Ccf 9171 memory vcpu mismatch (#155) * don't use default command line params for memory and vcpus * 0.12.9 * Bump lodash for vunerabilities CCF-9252 update generator for linux * CCF-9376 update generator version to 0.3.18 (#163) * CCF-9286: return instanceId in the message when promoting a snapshot … (#162) * CCF-9286: return instanceId in the message when promoting a snapshot to an environment that was being returned by the api response but not getting included in the cli response * updated message with review comments * fixing undefined error when promoting a snapshot to an environment, instanceId is under `response.message.instanceId` (#164) * working recursive upload of directory (#165) * working recursive upload of directory * 0.12.12 * Remove cortex-processors commands (#166) * Add agents list-snapshot-instances (#168) * Chunk directory upload (#169) * use sequential chunks of files to upload * 0.12.13 * Fix invalid query param on list snap instances (#170) * Updated list-services command to display the parameter names/types as well (#171) * CCF-9783 reverting changes to agent and catalog (#173) * Remove --timeout option from actions deploy (#175) * Ccf 9955 configure url (#176) * add protocol prefix if one is missing * 0.12.14 * Adds support for graph and profile APIs * Return error message from content upload properly * Bump generator-cortex to pick up with_type change * Support graph query in CLI * created template checklist as POC * updated pull_request_template * Update pull_request_template.md * Adds CLI support for Cortex Experiments * Adds progress bar to graph event publish for files * Bug fixes when attempting to craft manual test cases for the cli. * Reved package-log * Bumped version of cli and add proxying support * 0.12.17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix handling of non-http errors, like network or filesystem issues
Fix error propagation from getSourceFiles() in callbacks errors are typically first.