Allow use of Monolog 2.x (as well as 1.x)#64
Merged
miccheng merged 1 commit intoCoderKungfu:masterfrom Apr 9, 2021
Merged
Conversation
No changes needed to the Logger class itself, as the StreamHandler constructor is compatible in 2.x. Usages of non-PSR-standard e.g. Logger->addInfo() methods are replaced with PSR-standard e.g. Logger->info() calls, as both exist in 1.x and the former are removed in Monolog 2. See https://github.com/Seldaek/monolog/blob/main/UPGRADE.md
Member
|
Looks good. Thanks. I'll have to fix the Travis-CI bits later. |
Contributor
Author
|
Thanks so much for the speedy merge, @miccheng ! If it's not too much trouble, would you be able to tag a version 1.0.1 and update the version in packagist? |
Member
|
Done! |
Contributor
Author
|
Thanks again @miccheng ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No changes needed to the Logger class itself, as the StreamHandler
constructor is compatible in 2.x. Usages of non-PSR-standard e.g.
Logger->addInfo() methods are replaced with PSR-standard e.g.
Logger->info() calls, as both exist in 1.x and the former are
removed in Monolog 2.
See https://github.com/Seldaek/monolog/blob/main/UPGRADE.md