Skip to content

Remove shimmer animation from freebuff waiting room Wait time#523

Merged
jahooma merged 1 commit intomainfrom
jahooma/remove-shimmer-wait
Apr 20, 2026
Merged

Remove shimmer animation from freebuff waiting room Wait time#523
jahooma merged 1 commit intomainfrom
jahooma/remove-shimmer-wait

Conversation

@jahooma
Copy link
Copy Markdown
Contributor

@jahooma jahooma commented Apr 20, 2026

Unwraps the Wait time value in the freebuff waiting room from ShimmerText so it renders as plain static text. The shimmering wait estimate read as flickering noise next to the static Position and Elapsed rows; the other shimmer (the "Joining the waiting room…" placeholder) is preserved.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 20, 2026

Greptile Summary

This PR removes the ShimmerText animation wrapper from the wait time estimate in the freebuff waiting room, rendering it as plain static text instead. The ShimmerText component is still used for the "Joining the waiting room…" placeholder text, so the import is correctly retained.

  • Unwraps the Wait row's value from ShimmerText, replacing it with a plain inline expression
  • The ShimmerText import remains valid since it's still used for the loading placeholder at line 164
  • No logic changes — the conditional (position === 1 ? 'any moment now' : formatWait(session.estimatedWaitMs)) is preserved exactly

Confidence Score: 5/5

Safe to merge — minimal, isolated UI change with no logic impact.

Single-file, purely cosmetic change that removes an animation wrapper. The underlying conditional logic is untouched, the import is correctly preserved because ShimmerText is still used elsewhere in the same file, and there are no edge cases to worry about.

No files require special attention.

Important Files Changed

Filename Overview
cli/src/components/waiting-room-screen.tsx Removes ShimmerText wrapper from the Wait time row; import is still needed for the "Joining the waiting room…" placeholder at line 164. No logic changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[WaitingRoomScreen renders] --> B{session.status}
    B -- waiting --> C[Show Position / Wait / Elapsed rows]
    C --> D{session.position === 1?}
    D -- Yes --> E["Render 'any moment now' (plain text)"]
    D -- No --> F["Render formatWait(session.estimatedWaitMs) (plain text)"]
    B -- joining --> G["ShimmerText: 'Joining the waiting room…'"]
    B -- disabled --> H[Show disabled message]
Loading

Reviews (1): Last reviewed commit: "Remove shimmer animation from freebuff w..." | Re-trigger Greptile

@jahooma jahooma merged commit 9099292 into main Apr 20, 2026
34 checks passed
@jahooma jahooma deleted the jahooma/remove-shimmer-wait branch April 20, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant