London | 26-ITP-May | Ebrahim Moqbel | Sprint 2 | course work by Ebrahim-Moqbel · Pull Request #1582 · CodeYourFuture/Module-Structuring-and-Testing-Data

Ebrahim-Moqbel · 2026-07-28T13:50:10Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

reviewed the completed mandatory exercises and the key errors file further explaining and running the codes for revision purposes and submitting a new PR for the sprint

Questions

N/A

…dation

…sons

selyafi · 2026-07-29T12:43:12Z

-// =============> write your explanation here
-// =============> write your new code here
+}
+capitalise("ebrahim");


You call the function but never print it, so the file outputs nothing

selyafi · 2026-07-29T12:43:22Z

-// =============> write your new code here
+}
+capitalise("ebrahim");
+capitalise('salomi');


You call the function but never print it, so the file outputs nothing

selyafi · 2026-07-29T12:44:58Z

-  let str = `${str[0].toUpperCase()}${str.slice(1)}`;
-  return str;
-}
+return str[0].toUpperCase()+str.slice(1);


It is correct, but the code itself needs formatting. Missing indent inside the function

Still outstanding. Run npx prettier --write Sprint-2 from the repo root and it'll fix the formatting across all the files. Turning on format on save in VS Code will keep it that way.

selyafi · 2026-07-29T12:46:23Z

 //  =============> write your prediction here
+/*
+I predict the function will throw a SyntaxError as the variable str has already been declared in the function parameter  
+function capitalize will capitalise the first letter with index 0 


a typo in capitalize, since the function has different name.

selyafi · 2026-07-29T12:49:50Z

+/* the reason why getLastDigit isn't working properly is that it doesn't accept any arrguments where there isn't any perameters in its difination.
+where it uses the golabal varaible 'num' decalred outside the funtion and already set to 103
+
+The correct code includes a parameter 'number' in the difination this allows the function to accept the number passed to it when called*/


the parameter is num, not number

selyafi · 2026-07-29T12:52:29Z

-    // return the BMI of someone based off their weight and height
-}
+    let result = Number(weight/(height*height));
+    return result.toFixed(1);


I would drop the Number on the devision and than return Number(..)

selyafi · 2026-07-29T12:55:37Z

 // You will need to come up with an appropriate name for the function
 // Use the MDN string documentation to help you find a solution
 // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase
+function toUpperSnakeFormat(string){


rename to match the vocabulary brief in the link, i.e toUpperSnakeCase

Coming back to this one. The function is still called toUpperSnakeFormat. Rename it to toUpperSnakeCase to match the wording in the exercise, or tell me why you prefer the current name.

Ebrahim-Moqbel · 2026-08-19T09:32:33Z

I have committed the suggested changes and answered the questions if there is any further requirements please do let me know @selyafi

Thank you

abdishakoor-dev

I have left some comments inline. Once those are resolved I'll mark this Complete.

abdishakoor-dev · 2026-08-20T17:21:45Z


 // =============> write your explanation here
+/* The variable decimal Number has already been declared in the parameter 
+ and already is a local variable which can't be declared again causing a ReferenceError  


Try running the original code. That's a SyntaxError, not a ReferenceError, and it stops the file before anything runs, so the console.log problem you predicted never happens. Update your explanation to match.

abdishakoor-dev · 2026-08-20T17:21:45Z


 // =============> explain this error message here
+/* The function was givin a number as its perameter where in JS only allows varaible names and usnig a number causes a SyntaxError
+ Also, the function was returning num*num where num is undefined causing a ReferenceError


Same thing here. function square(3) is a SyntaxError, so the file never runs and num * num never executes. Delete the last sentence about the ReferenceError.

abdishakoor-dev · 2026-08-20T17:21:45Z


 // b) What is the value assigned to num when pad is called for the first time?
-// =============> write your answer here
+// =============> the first time pad was called with the totalHours


Answer with the value, not the variable name. Run formatTimeDisplay(61) and check what totalHours is at that point.

abdishakoor-dev · 2026-08-20T17:21:46Z


 // d) What is the value assigned to num when pad is called for the last time in this program?  Explain your answer
-// =============> write your answer here
+// =============> "1"


Check where remainingSeconds comes from and fix the answer. pad is what turns it into a string, on its first line.

Ebrahim-Moqbel added 15 commits February 24, 2026 01:35

explaining line line 3

51a060d

creating initials from a string

795be43

solved the exercises

2b4173b

interpreting the programs

c77e1c3

explored console in the developer tools and answered some Qs

e829acf

answered the exercises of the key errors and debug the mandatory file

14fee9a

solved the 3-mandatory implement file

d424070

solved the mandatory interpret

2eaa851

Deleted the changes of the sprint one file to meet the mata Data vali…

1c37d58

…dation

reviwing the content for updates and polishing my explanations

4d8de06

revising and reviewing the content further expalining some of the rea…

69791bc

…sons

revising and reviewing the content further expalining some of the rea…

97abaaa

…sons

Merge branch 'main' into acoursework/sprint-2

3fcb050

explain the return value of using the function pad

2efa343

commiting the changes

4435e7f

Ebrahim-Moqbel added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jul 28, 2026

selyafi reviewed Jul 29, 2026

View reviewed changes

comitting changes to march the reviewer suggestions

c234195

Ebrahim-Moqbel mentioned this pull request Aug 18, 2026

26-May-ITP | Structuring and testing data | Ebrahim Moqbel Ebrahim-Moqbel/Ebrahim-Planner-board#54

Open

abdishakoor-dev reviewed Aug 20, 2026

View reviewed changes

abdishakoor-dev added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Aug 20, 2026

abdishakoor-dev removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 20, 2026

Uh oh!

Uh oh!

Conversation

Ebrahim-Moqbel commented Jul 28, 2026

Learners, PR Template

Changelist

Questions

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ebrahim-Moqbel commented Aug 19, 2026

Uh oh!

abdishakoor-dev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

abdishakoor-dev left a comment •

edited

Loading