Skip to content

London | 26-ITP-May | Gideon Defar | Sprint 1 | Coursework - #1553

Open
gideondefar wants to merge 16 commits into
CodeYourFuture:mainfrom
gideondefar:coursework/sprint-1
Open

London | 26-ITP-May | Gideon Defar | Sprint 1 | Coursework#1553
gideondefar wants to merge 16 commits into
CodeYourFuture:mainfrom
gideondefar:coursework/sprint-1

Conversation

@gideondefar

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

In this PR, I have completed the required Sprint 1 coursework exercises.

  • Resolved debugging and initialization order errors within the mandatory errors folder.
  • Added comprehensive documentation and step-by-step breakdowns for the math logic (such as remainder operations and random integer formulas) and string manipulation files.
  • Verified all JavaScript code runs cleanly using Node.js without terminal crashes.

Questions

How do you recommend formatting long multi-line explanations or breakdowns for formulas in the code? Is a detailed block comment preferred over individual single-line comments according to the style guide?

@gideondefar gideondefar added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module labels Jul 23, 2026
Comment thread Sprint-1/1-key-exercises/2-initials.js Outdated
Comment thread Sprint-1/1-key-exercises/3-paths.js
Comment thread Sprint-1/2-mandatory-errors/4.js Outdated
Comment thread Sprint-1/3-mandatory-interpret/1-percentage-change.js Outdated
Comment thread Sprint-1/3-mandatory-interpret/1-percentage-change.js
Comment thread Sprint-1/3-mandatory-interpret/1-percentage-change.js
@webmonch

Copy link
Copy Markdown

I believe 0.js and 3.js in the mandatory errors section also require a solution. I also noticed that not all of the files run without errors. As a general practice, it’s worth running each file before pushing your changes to make sure there are no syntax or runtime errors.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 27, 2026
@cjyuan

cjyuan commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Note: It seems this PR has been reviewed. So I changed to label to Reviewed.

@gideondefar gideondefar added the Module-Structuring-And-Testing-Data The name of the module. label Jul 30, 2026
@gideondefar gideondefar added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 2, 2026
@gideondefar

Copy link
Copy Markdown
Author

I believe 0.js and 3.js in the mandatory errors section also require a solution. I also noticed that not all of the files run without errors. As a general practice, it’s worth running each file before pushing your changes to make sure there are no syntax or runtime errors.
Thanks for pointing that out. I’ve now fixed 0.js and 3.js and run all the files in the mandatory errors section to check for syntax and runtime errors.

@webmonch webmonch removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 15, 2026
@webmonch webmonch added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Aug 15, 2026
Comment thread Sprint-1/1-key-exercises/3-paths.js Outdated
Comment thread Sprint-1/2-mandatory-errors/2.js
@webmonch

Copy link
Copy Markdown

Good job! Most of the issues have been resolved, only few tiny ones left.

@webmonch webmonch added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 15, 2026
@gideondefar gideondefar added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 15, 2026
@gideondefar

gideondefar commented Aug 20, 2026

Copy link
Copy Markdown
Author

Good job! Most of the issues have been resolved, only few tiny ones left.

Could you please tell me a specific bug, so I can fix it. I couldn't see unresolved issue; I guess I have fixed all your feedback.

@cjyuan

cjyuan commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

@gideondefar I think these two unresolved comments have not yet been addressed:
#1553 (comment)
#1553 (comment)

@gideondefar

Copy link
Copy Markdown
Author

@gideondefar I think these two unresolved comments have not yet been addressed: #1553 (comment) #1553 (comment)

I carefully go through them and resolved the issue thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Structuring-And-Testing-Data The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants