LONDON | GISLAINE_DELLA_BELLA | Module-Structuring-and-Testing-Data | SPRINT 1 - #143
Closed
Della-Bella wants to merge 0 commit into
Closed
LONDON | GISLAINE_DELLA_BELLA | Module-Structuring-and-Testing-Data | SPRINT 1#143Della-Bella wants to merge 0 commit into
Della-Bella wants to merge 0 commit into
Conversation
SallyMcGrath
suggested changes
Nov 18, 2024
SallyMcGrath
left a comment
Member
There was a problem hiding this comment.
Hi there @Della-Bella
It looks like you have made changes to many files across many folders. Take a look https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/pull/143/files
You have loads more files in this list than you should. You need to make changes only to the relevant files in a PR. Lots of people have trouble with this, so look in the questions channel on Slack to get help with fixing this. Good luck!
Author
|
Hi Sally, good evening I will ask for help to understand and fix it. thanks again for your time, Gislaine |
Author
|
A volunteer was trying to revert my commits but some of them got deleted so I will create a new PR to commit all my changes related to Sprint 1. Please find my new PR here: #187 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Hi volunteer,
Here are my exercises from Sprint 1.
I had to ignore my first branch f and restart again as I was making my changes only in one branch and even following what CJ Juan posted on Slack I couldn't merge the last with the new. So here is going again/exercises Sprint 1.
Thank you for taking the time to review them.
Gislaine