Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 1 | New Feature: Rebloom - New - #262
Open
HassanOHOsman wants to merge 19 commits into
Open
Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 1 | New Feature: Rebloom - New#262HassanOHOsman wants to merge 19 commits into
HassanOHOsman wants to merge 19 commits into
Conversation
illicitonion
left a comment
Member
There was a problem hiding this comment.
This generally looks good, but a few thoughts, as well as not needing a reblooms table:
- Right now when you show a rebloom it doesn't look like a rebloom - it looks like a new bloom by the reblooming user - how could you indicate that it's a rebloom (ideally showing what user it's a rebloom from)?
- I think there's a caching issue that means when you rebloom something, your own profile timeline doesn't get invalidated, so if you do a rebloom then go to your own profile it doesn't show up until you refresh
| UNIQUE(hashtag, bloom_id) | ||
| ); | ||
|
|
||
| CREATE TABLE reblooms ( |
Member
There was a problem hiding this comment.
You shouldn't need a separate table for reblooms - you have all the information you need in the blooms table with original_bloom_id, but may need to do some joins to get the data out
HassanOHOsman
force-pushed
the
feature/re-bloom
branch
from
August 21, 2026 15:28
d42592a to
b2dcd10
Compare
2. add a test content for th erebloom counter
Author
|
Not the best... still needs some work. however, the caching issue is now resolved as far as I could tell from my end. Let me know if I still need to change or do anything. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Questions
I just could not display the reblooms on my logged in user's timelines. I've spent a few days on it but to no avail.