london_10|shadi_fakhri|ModuleDataBases|big-spender_week_1 - #70
Open
Shadi38 wants to merge 1 commit into
Open
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
llamojha
reviewed
Sep 1, 2023
| FROM spends | ||
| INNER JOIN suppliers ON suppliers.id = spends.supplier_id | ||
| GROUP BY suppliers.supplier, spends.supplier_id | ||
| order by supplier_id;q |
There was a problem hiding this comment.
Small comment here, keep the consistency for SQL statetments. For example, here the 'order by' is all in lowercase while other statements like 'GROUP BY' or 'INNER JOIN" are all in uppercase. Usually is good practice to keep those in uppercase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.