This repository was archived by the owner on Oct 26, 2020. It is now read-only.
Week 1/mandatory/leroy douglas - #1
Open
leroy-douglas wants to merge 4 commits into
Open
Conversation
Added comments for s(w1, w2) and getNumber(). Also added code to the body of concatenate(s1, s2, s3)
Updated calculateSalesTax(price) and formatCurrency(price)
leroy-douglas
marked this pull request as draft
June 16, 2020 18:45
leroy-douglas
marked this pull request as ready for review
June 16, 2020 18:46
Rody-Kirwan
approved these changes
Jun 29, 2020
| * e.g if the function is call with the following arguments: s("Hello", " World!"), where the | ||
| * second argument is prepended with a space, then the function will return the following string: | ||
| * "Hello World!" | ||
| */ |
There was a problem hiding this comment.
FYI - these could potentially be arrays also :)
[1, 2, 3].concat([4, 5, 6]) // returns [1, 2, 3, 4, 5, 6]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your Details
Your Name: Leroy Douglas
Your City: Birmingham
Your Slack Name: Leroy
Homework Details
Module: JavaScript-Core-1
Week: 1