Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

ZA2-Kwanda Silekwa-JavaScript-Core-1-Coursework-Week-3 - #67

Open
kwanda9700 wants to merge 10 commits into
CodeYourFuture:mainfrom
kwanda9700:main
Open

ZA2-Kwanda Silekwa-JavaScript-Core-1-Coursework-Week-3#67
kwanda9700 wants to merge 10 commits into
CodeYourFuture:mainfrom
kwanda9700:main

Conversation

@kwanda9700

@kwanda9700 kwanda9700 commented Jul 21, 2022

Copy link
Copy Markdown

No description provided.

dschouw-CYF
dschouw-CYF reviewed Jul 25, 2022
View reviewed changes

@dschouw-CYF dschouw-CYF left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Kwanda! Keep it up!

Comment thread 1-exercises/B-while-loop/exercise.js

function evenNumbers(n) {
// TODO
let i = 0;

@dschouw-CYF dschouw-CYF Jul 25, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function evenNumbers(10) should log [0,2,4,6,8] in its current form.
Looking at the expected output of invoking it (line 20) for argument 3, it should log 0,2,4.
It seems like the function evenNumbers should log the first n even numbers, where n is the argument to the function.

Comment thread 1-exercises/C-while-loop-with-array/exercise.js

function findFirstJulyBDay(birthdays) {
// TODO
arrayLength = birthdays.length;

@dschouw-CYF dschouw-CYF Jul 25, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

Comment thread 1-exercises/E-for-loop/exercise1.js
// i++;
// }

for (i; i < 26; i++) {

@dschouw-CYF dschouw-CYF Jul 25, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit of code raises a ReferenceError.
What do you think is missing from the for statement?

Comment thread 1-exercises/F-for-of-loop/exercise.js
"Tottenham Court Road",
];

for (let i = 0; i < tubeStations.length; i++) {

@dschouw-CYF dschouw-CYF Jul 25, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!.
This works perfectly fine, but the requirement is to use a for-of loop.
See MDN and W3Schools for more information.

Comment thread 1-exercises/F-for-of-loop/exercise.js
// TODO Use a for-of loop to capitalise and output each letter in the string seperately.
let str = "codeyourfuture";

for (let i = 0; i < str.length; i++) {

@dschouw-CYF dschouw-CYF Jul 25, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly fine!
Using the same comment above though, attempt this with the for-of loop

Comment thread 2-mandatory/1-weather-report.js
// TODO
// TODO
let temperatureReport = [];
cities.forEach((cityName) => {

@dschouw-CYF dschouw-CYF Jul 25, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of .forEach!

Comment thread 2-mandatory/2-retrying-random-numbers.js

function getRandomNumberGreaterThan50() {
// TODO - implement using a do-while loop
// TODO - implement using a do-while loop

@dschouw-CYF dschouw-CYF Jul 25, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Comment thread 2-mandatory/3-financial-times.js
function potentialHeadlines(allArticleTitles) {
// TODO
// TODO
let potentialArticles = allArticleTitles.filter(

@dschouw-CYF dschouw-CYF Jul 25, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Good use of .filter()

Comment thread 2-mandatory/3-financial-times.js
// TODO
for (let shortestTitle of allArticleTitles) {
let fewestWordTitle = shortestTitle.split(" ");
if (fewestWordTitle.length <= 7) {

@dschouw-CYF dschouw-CYF Jul 25, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the number 7 used to determine the fewest words?
This might be a case of magic numbers and should be avoided when coding.
If a new title, with a even shorter title is introduced, will this function still work?

Comment thread 2-mandatory/3-financial-times.js
function headlinesWithNumbers(allArticleTitles) {
// TODO
// TODO
let titleWithNumArr = [];

@dschouw-CYF dschouw-CYF Jul 25, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regex 😳 . Nice Work!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@dschouw-CYF dschouw-CYF dschouw-CYF left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kwanda9700 @dschouw-CYF