Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

ZA-2 Marvin Marshall_ JS_core - WK3. - #56

Open
MarvinLeeMarshall wants to merge 1 commit into
CodeYourFuture:mainfrom
MarvinLeeMarshall:main
Open

ZA-2 Marvin Marshall_ JS_core - WK3.#56
MarvinLeeMarshall wants to merge 1 commit into
CodeYourFuture:mainfrom
MarvinLeeMarshall:main

Conversation

@MarvinLeeMarshall

Copy link
Copy Markdown

ZA-2 Marvin Marshall_ JS_core - WK3.

ZA-2 Marvin Marshall_ JS_core - WK3.

@M3ntalist M3ntalist left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Marvin, just take a look at some of your work. Great work man

temperatureReport.push(`The temperature in ${city} is ${cityTemp} degrees`);
}
return temperatureReport;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your function is undefined @MarvinLeeMarshall

Comment thread 2-mandatory/4-stocks.js
highestPriceForEachStock.push(
`The highest price of ${stocks[
i
].toUpperCase()} in the last 5 days was ${Math.max(

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Marvin: There is an "Uncaught Reference Error: closingPricesForAllStocks is not defined"


// TODO Use a for-of loop to capitalise and output each letter in the string seperately.
let str = "codeyourfuture";
for (let i = 0; i < str.length; i++){

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, good work

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants