This repository was archived by the owner on Jan 14, 2024. It is now read-only.
ZA2 - Anthony Mogotlane - JavaScript-Core-1-Coursework - W3 - #53
Open
AnthonyMogotlane wants to merge 6 commits into
Open
ZA2 - Anthony Mogotlane - JavaScript-Core-1-Coursework - W3#53AnthonyMogotlane wants to merge 6 commits into
AnthonyMogotlane wants to merge 6 commits into
Conversation
dschouw-CYF
reviewed
Jul 25, 2022
dschouw-CYF
left a comment
There was a problem hiding this comment.
Thank you for your submission Anthony, awesome work!
|
|
||
| function evenNumbers(n) { | ||
| // TODO | ||
| let res = []; |
|
|
||
| function getTemperatureReport(cities) { | ||
| // TODO | ||
| return cities.map(town => `The temperature in ${town} is ${temperatureService(town)} degrees`) |
|
|
||
| function getRandomNumberGreaterThan50() { | ||
| // TODO - implement using a do-while loop | ||
| let rand = generateRandomNumber(); |
There was a problem hiding this comment.
The function getRandomNumberGreaterThan50() invokes generateRandomNumber() only once.
The do/while loop then executes until the result of the generateRandomNumber() returns a value greater than zero.
Will the do/while loop ever complete?
| */ | ||
| function potentialHeadlines(allArticleTitles) { | ||
| // TODO | ||
| return allArticleTitles.filter(title => { |
There was a problem hiding this comment.
Good use of .filter().
Filter is a predicate function , so you can also just return the result of a boolean evaluation and it should still work.
Well done
| */ | ||
| function titleWithFewestWords(allArticleTitles) { | ||
| // TODO | ||
| let num = Math.min(...allArticleTitles.map(title => title.split(" ").length)); |
| */ | ||
| function getAveragePrices(closingPricesForAllStocks) { | ||
| // TODO | ||
| return closingPricesForAllStocks.map(priceArr => { |
| return `The highest price of ${stocks[i].toUpperCase()} in the last 5 days was ${Math.max(...priceArr).toFixed(2)}`; | ||
| }) | ||
| } | ||
| console.log(highestPriceDescriptions(CLOSING_PRICES_LAST_5_DAYS_FOR_ALL_STOCKS, STOCKS)); |
There was a problem hiding this comment.
Really well done on your solutions for this exercise Anthony 🔥
| Using a loop, complete the function below so it returns the factorial of the number being passed in. | ||
| */ | ||
|
|
||
| // Solved it using recursion instead of a loop |
There was a problem hiding this comment.
👀 Much more elegant than the official solution 🤣
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.