finished mandatory and exercises - #34
Conversation
|
|
||
| function getTemperatureReport(cities) { | ||
| // TODO | ||
| let tempDetailArr = [] |
There was a problem hiding this comment.
nice code structure, easy to read. Great work Monika
beckyf0keefe
left a comment
There was a problem hiding this comment.
Generally everything looking good, just make sure you are paying close attention to the details <50 not the same as <=50. Good naming of variables like we talked about. If you have time please take a look at the title with fewest works function and see if you can make it work for all situations by replacing 6 with a variable.
| generateRandomNumber() | ||
| randNumber = generateRandomNumber() | ||
|
|
||
| } while (randNumber < 50) |
There was a problem hiding this comment.
What happens here if the random number is 50? Should the loop be carrying on? Will it?
| // TODO | ||
| for (let title of allArticleTitles) { | ||
| let titleWordsArr = title.split(' '); | ||
| if (titleWordsArr.length <= 6 ) { |
There was a problem hiding this comment.
Where does this 6 come from? Is there something else that we can compare to that would work even if all the titles are longer than 6 words?
No description provided.