This repository was archived by the owner on Jan 14, 2024. It is now read-only.
exercises - #31
Open
teniolao wants to merge 2 commits into
Open
Conversation
AmarachiOkereke
left a comment
There was a problem hiding this comment.
Great job Teniola, didn't see any error in your exercise folder.
jacint-david
left a comment
There was a problem hiding this comment.
Great Job @teniolao ! Very readable code! 🎉 😄
MatenRehimi
reviewed
Jan 31, 2022
|
|
||
| function getRandomNumberGreaterThan50() { | ||
| // TODO - implement using a do-while loop | ||
| let i = 0; |
There was a problem hiding this comment.
Would we need the variable i in this function?
MatenRehimi
reviewed
Jan 31, 2022
| let priceChange = []; | ||
| for (let prices of closingPrices) { | ||
| let change = prices[prices.length - 1] - prices[0]; | ||
| priceChange.push(rounded(change)); |
There was a problem hiding this comment.
Did you mean Math.round rather than rounded?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.