London Class 8 - Daniel Piga- JavaScript-Core-1-Coursework-Week3 London 8 by pigos4 · Pull Request #3 · CodeYourFuture/JavaScript-Core-1-Coursework-Week3

pigos4 · 2022-01-09T14:00:27Z

No description provided.

DelroyGayle

Excellent coding.
I have a suggestion:
Seeing that you are using more advanced JavaScript than the majority of us.
Could you please add comments to your code so others (such as myself)
can learn and understand what your code is doing.
Thank you

DelroyGayle · 2022-01-10T10:44:47Z

@@ -6,7 +6,13 @@
 */

 function evenNumbers(n) {


Greetings Daniel
It has been a brain-growing experience reviewing your code. :)
Excellent.
However, I do have some suggestions:

It took me a while to figure out why you were using n * 2 and count % 2
Instead add '2' to your total instead of adding 1 each time.
That way, you can keep the limit as 'n' and there will be no need for the usage of %.
So have one variable for your total, another for your count; so that you have while (count < n)
Start of with total=zero. And then each time you repeat the loop, add 2.

Hello Delroy,
Yes, I think your is a better solution only adding the two numbers to the string is easy.
Thanks

You are most welcome. Great work!

DelroyGayle · 2022-01-10T11:02:45Z

@@ -7,9 +7,16 @@
 */

 function evenNumbersSum(n) {


Dear Daniel
Unfortunately, this function does not work properly.
For example, the sum of the first n numbers when
n=1: should be 0,
n=2: 0 + 2 Should be 2
n=3: 0 + 2 + 4 Should be 6
n=4: 0 + 2 + 4 + 6 Should be 12
n=5: 0 + 2 + 4 + 6 + 8 Should be 20

However when I tested your function it gave the wrong answers for n=2,4,5.
So it needs to be redone.

Look at my other comments regarding evenNumbers(n) as a starting point.

Yes thanks, is not working properly.

DelroyGayle · 2022-01-10T11:07:47Z

+  "Yukiko Motoya",
 ];

+const AGES = [59, 40, 41, 63, 49];


DelroyGayle · 2022-01-10T11:08:20Z

+}

 // TODO Use a for-of loop to capitalise and output each letter in the string seperately.
 let str = "codeyourfuture";


DelroyGayle · 2022-01-10T11:09:13Z


 function getTemperatureReport(cities) {
-    // TODO
+  return cities


Wow Daniel. .map and arrow notation!
Simply amazing

DelroyGayle · 2022-01-10T12:01:01Z

@@ -34,9 +34,14 @@ const CLOSING_PRICES_LAST_5_DAYS_FOR_ALL_STOCKS = [
        Functions can help with this!
 */


.map .reduce
Amazing!

DelroyGayle · 2022-01-10T12:02:39Z

@@ -48,7 +53,10 @@ function getAveragePrices(closingPricesForAllStocks) {
    The price change value should be rounded to 2 decimal places, and should be a number (not a string)


Is the * 1 used to convert a string to a number?

Yes because toFixed(2) returns a string

DelroyGayle · 2022-01-10T12:03:52Z

@@ -64,31 +72,38 @@ function getPriceChanges(closingPricesForAllStocks) {
    The price should be shown with exactly 2 decimal places.
 */
 function highestPriceDescriptions(closingPricesForAllStocks, stocks) {


DelroyGayle · 2022-01-10T12:18:24Z

@@ -11,72 +11,75 @@
 */

 function getHighestRatedInEachGenre(books) {


DelroyGayle · 2022-01-10T12:18:53Z

-function generateFibonacciSequence(n) {
-    // TODO
-}
+function generateFibonacciSequence(num) {


DelroyGayle

Daniel, it has been a pleasure looking at your code. You have given me many new ideas.
Thank you.

DelroyGayle · 2022-01-10T12:52:06Z

+  do {
+    res = generateRandomNumber();
+  } while (res <= 50);
+  if (res > 50) return res;


Hi Daniel. There is no need for the 'if' statement here since the while loop is finished when res is larger than 50
So you only need to do the return here.

DelroyGayle · 2022-01-10T20:34:03Z

@@ -7,9 +7,16 @@
 */

 function evenNumbersSum(n) {


DelroyGayle · 2022-01-10T20:35:13Z

@@ -6,7 +6,13 @@
 */

 function evenNumbers(n) {


You are most welcome. Great work!

kolomiets

Good job @pigos4 :)

map/filter/reduce are very good friends, you'll see them a lot in practice. The habit of thinking about programming problems as about operations over collections can get you very far - this is a very powerful technique.

kolomiets · 2022-01-14T21:32:27Z

@@ -0,0 +1,5 @@
+{


Consider using .gitignore to simplify the management of local files you don't want to push for a review. This is a good practice to master :)

kolomiets · 2022-01-14T21:35:40Z

 function findFirstJulyBDay(birthdays) {
-    // TODO
+  for (let day of birthdays) {
+    if (day === "July 11th") return day;


This passes the test but technically this is not correct. If I update BIRTHDAY and add a new July date before "July 11th" - the code will not work correctly.

I'd expect it to be day. startsWith("July")

kolomiets · 2022-01-14T21:40:25Z


 function getTemperatureReport(cities) {
-    // TODO
+  return cities.map(function(city){ return`The temperature in ${city} is ${temperatureService(city)} degrees`}


Could be even more streamlined with lambdas :)

return cities.map(city =>The temperature in ${city} is ${temperatureService(city)} degrees

kolomiets · 2022-01-14T21:46:40Z

 */
 function titleWithFewestWords(allArticleTitles) {
-    // TODO
+  return allArticleTitles.sort((a, b) => a.split(" ").length - b.split(" ").length)[0];


This may not be actually correct. You return the shortest title (meaning the title that contains the minimum number of letters). Instead, you need to find a title that has the fewest number of words.

kolomiets · 2022-01-14T21:47:22Z

 */
 function titleWithFewestWords(allArticleTitles) {
-    // TODO
+  return allArticleTitles.sort((a, b) => a.split(" ").length - b.split(" ").length)[0];


Be careful with [0] - your function will crash for empty list of titles.

kolomiets · 2022-01-14T21:57:21Z

+  let genres =  books.reduce((acc,book) => {
+    //If the genre isn't in the initial value initial value is = to book or if the genre is in the 
+    // initial value but is less than current value change the value to the current book
+    if (!acc[book.genre] || acc[book.genre].rating < book.rating)acc[book.genre] = book;


Some languages/programming styles allow if without curly braces or even with body on the same line. JavaScript style conventions generally discourage this. Do consider more "traditional" way of writing this:

if (!acc[book.genre] || acc[book.genre].rating < book.rating) { acc[book.genre] = book; } return acc

kolomiets · 2022-01-14T22:14:32Z

+//     The list of numbers should start with 0. n is being passed in as a parameter.
+// */

 function evenNumbers(n) {


Since you like operations over collections, how about this :)

function evenNumbers(n) { console.log([...Array(n).keys()].map(x => x * 2).join(',')) }

Tasks completed

f79c633

DelroyGayle reviewed Jan 10, 2022

View reviewed changes

fixed two problem in exercise and improved 2-array of objects

1c23fab

DelroyGayle reviewed Jan 10, 2022

View reviewed changes

fixed 3-finacialtime titleWithFewestWords

0ac13ea

kolomiets reviewed Jan 14, 2022

View reviewed changes

kolomiets added the reviewed A mentor has reviewed this code label Jan 14, 2022

kolomiets reviewed Jan 14, 2022

View reviewed changes

		@@ -34,9 +34,14 @@ const CLOSING_PRICES_LAST_5_DAYS_FOR_ALL_STOCKS = [
		Functions can help with this!
		*/

		@@ -48,7 +53,10 @@ function getAveragePrices(closingPricesForAllStocks) {
		The price change value should be rounded to 2 decimal places, and should be a number (not a string)

		@@ -11,72 +11,75 @@
		*/

		function getHighestRatedInEachGenre(books) {

Uh oh!

Uh oh!

Conversation

pigos4 commented Jan 9, 2022

Uh oh!

DelroyGayle left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pigos4 Jan 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DelroyGayle left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kolomiets left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pigos4 Jan 10, 2022 •

edited

Loading